From: Marek Vasut <marex@denx.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Huang Shijie <shijie8@gmail.com>,
Chunhe Lan <Chunhe.Lan@freescale.com>
Subject: Re: [PATCH] mtd: spi-nor: Move n25q032 entry to Micron devices list
Date: Wed, 29 Oct 2014 20:54:54 +0100 [thread overview]
Message-ID: <201410292054.54381.marex@denx.de> (raw)
In-Reply-To: <CACna6rwFmtG01B2xwNgV9vrk945v5On1Mvm=4qfJP4Kxs-Oe8g@mail.gmail.com>
On Wednesday, October 29, 2014 at 08:43:32 PM, Rafał Miłecki wrote:
> On 29 October 2014 20:19, Marek Vasut <marex@denx.de> wrote:
> > On Wednesday, October 29, 2014 at 06:40:46 PM, Rafał Miłecki wrote:
> >> On 29 October 2014 15:05, Marek Vasut <marex@denx.de> wrote:
> >> > On Wednesday, October 29, 2014 at 10:57:55 AM, Chunhe Lan wrote:
> >> >
> >> > [...]
> >> >
> >> > There are problems with this patch. Firstly, it misses any description
> >> > explaining why the change took place at all. From an outside observer
> >> > point of view, this change seems random at best.
> >>
> >> This looks like a normal cleaning for me.
> >
> > We can only guess, since the commit message is missing.
>
> Maybe the topic says everything the patch does :)
Maybe :)
> >> > I can only speculate here, that your SPI NOR was
> >> > recognised as some other part, right ? That's why moving the n25q032
> >> > higher resolved the problem for you, right ?
> >> >
> >> > The problem is with the fragility of this code which matches the JEDEC
> >> > ID and type of the SPI NOR. I recall Huang had some patches which
> >> > tried to resolve this, not sure what the status of those patches is
> >> > though.
> >>
> >> Wait, what? OK, this makes things tricky. Does this patch really
> >> change any behavior? How does it happen? I don't see any duplicated
> >> entry with the same JEDEC ID (0x20ba16).
> >>
> >> Could you give us some more details?
> >
> > Please see this thread:
> > http://lists.infradead.org/pipermail/linux-mtd/2014-April/053308.html
> >
> > This is where the discussion about ordering in the table took place
> > and where the patch for implementing the support for length of READID
> > return value was proposed.
>
> As I said, entry "n25q032" doesn't share JEDEC with anything else and
> does not even have an ext_id. So I don't think it's related to the
> s25fl128s vs. s25fl129p1 problem.
I hope that's the case. Clearly, proper commit message would help clarify
this case ;-)
Best regards,
Marek Vasut
prev parent reply other threads:[~2014-10-29 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 9:57 [PATCH] mtd: spi-nor: Move n25q032 entry to Micron devices list Chunhe Lan
2014-10-29 14:05 ` Marek Vasut
2014-10-29 17:40 ` Rafał Miłecki
2014-10-29 19:19 ` Marek Vasut
2014-10-29 19:43 ` Rafał Miłecki
2014-10-29 19:54 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410292054.54381.marex@denx.de \
--to=marex@denx.de \
--cc=Chunhe.Lan@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie8@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox