From: Brian Norris <computersforpeace@gmail.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"David Woodhouse" <David.Woodhouse@intel.com>,
"Artem Bityutskiy" <dedekind1@gmail.com>
Subject: Re: [PATCH] mtd: nand: print erase size on init
Date: Tue, 25 Nov 2014 19:02:50 -0800 [thread overview]
Message-ID: <20141126030250.GP24364@ld-irv-0074> (raw)
In-Reply-To: <54712F77.9000200@vanguardiasur.com.ar>
On Sat, Nov 22, 2014 at 09:51:03PM -0300, Ezequiel Garcia wrote:
> On 10/30/2014 09:35 AM, Rafał Miłecki wrote:
> > On 30 October 2014 08:33, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> >> On Wed, 2014-10-22 at 19:48 -0300, Ezequiel Garcia wrote:
> >>> Moreover, you have a /proc and a /sysfs interface to retrieve the erasesize:
> >>>
> >>> What's wrong with using any of the currently available interfaces:
> >>>
> >>> $ cat /sys/class/mtd/mtd0/erasesize
> >>> 131072
> >>>
> >>> $ cat /proc/mtd | grep mtd0 | awk '{print $3}'
> >>> 00020000
> >>>
> >>> Any reason why you want the info in the kernel log?
> >>
> >> When people ask for help and send their logs, it is very handy to have
> >> this information there.
> >
> > Oops, forgot to reply. There are two reasons for this:
> > 1) It's easier to get erasesize from users/reporters when it simply
> > appears in the boot log.
> > 2) If user space breaks (e.g. because of wrong UBI image) we can't use
> > "cat" to read the erasesize
> >
>
> Hm.. OK. Those sound like good reasons.
Glad we can agree on this important issue :)
Pushed to l2-mtd.git.
Brian
prev parent reply other threads:[~2014-11-26 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 22:01 [PATCH] mtd: nand: print erase size on init Rafał Miłecki
2014-10-22 22:48 ` Ezequiel Garcia
2014-10-30 7:33 ` Artem Bityutskiy
2014-10-30 12:35 ` Rafał Miłecki
2014-11-23 0:51 ` Ezequiel Garcia
2014-11-26 3:02 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126030250.GP24364@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=dedekind1@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox