From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pd0-x22f.google.com ([2607:f8b0:400e:c02::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xv0VK-0005JZ-4V for linux-mtd@lists.infradead.org; Sun, 30 Nov 2014 09:09:18 +0000 Received: by mail-pd0-f175.google.com with SMTP id y10so8956229pdj.6 for ; Sun, 30 Nov 2014 01:08:57 -0800 (PST) Date: Sun, 30 Nov 2014 01:08:53 -0800 From: Brian Norris To: Zhou Wang Subject: Re: [PATCH v4 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc Message-ID: <20141130090853.GG3608@norris-Latitude-E6410> References: <1415105221-7732-1-git-send-email-wangzhou.bry@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1415105221-7732-1-git-send-email-wangzhou.bry@gmail.com> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, haojian.zhuang@gmail.com, wangzhou1@hisilicon.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, xuwei5@hisilicon.com, galak@codeaurora.org, caizhiyong@huawei.com, David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Nov 04, 2014 at 08:46:59PM +0800, Zhou Wang wrote: > This patchset adds the support for NAND controller of hisilicon hip04 Soc. > The NAND controller IP was developed by hisilicon and needs a new driver to > support it. This patchset is based on v3.18-rc1. I have tested that NAND flash > controller works fine in Hip04 D01 board. Have you tested on the MTD test modules (drivers/mtd/tests/*)? This is important, as we seem to regularly get UBIFS bug reports from users whose drivers have not even passed some of the simple tests. Also, it might be worth testing out the UBI tests found in the mtd-utils package. Brian