Re: [PATCH v3 1/3] mtd: nand: add asm9260 NFC driver

[Boris Brezillon <boris.brezillon@free-electrons.com>]

On Wed, 31 Dec 2014 17:48:59 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> Hi Oleksij,
> 
> You should really add a cover letter containing a changelog (updated at
> each new version of your cover letter) so that reviewers can easily
> identify what has changed.
> 
> While you're at it, can you add your mtd test results to the cover
> letter ?
> 
> On Wed, 31 Dec 2014 13:58:51 +0100
> Oleksij Rempel <linux@rempel-privat.de> wrote:
> 
> > Add driver for Nand Flash Controller used on Alphascales ASM9260 chips.
> > The IP core of this controller has some similarities with
> > Evatronix NANDFLASH-CTRL IP (unknown revision), so probably it can be reused
> > by some other SoCs.
> > 
> > Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> > ---
> >  drivers/mtd/nand/Kconfig        |   7 +
> >  drivers/mtd/nand/Makefile       |   1 +

[...]

> > +
> > +static void asm9260_nand_set_addr(struct asm9260_nand_priv *priv,
> > +		u32 row_addr, u32 column)
> > +{
> > +	u32 addr[2];
> > +
> > +	addr[0] = (column & 0xffff) | (0xffff0000 & (row_addr << 16));
> > +	addr[1] = (row_addr >> 16) & 0xff;
> 
> Another nit: will this always work (especially on big endian
> kernels) ?
> 

Forget that one, it will work just fine (sorry for the brainfart).


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com