Re: [PATCH v2] mtd: nftl: reorganize operations in condition check

[Giel van Schijndel <me@mortis.eu>]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

On Sat, Jan 10, 2015 at 14:56:32 +0200, Andy Shevchenko wrote:
> On Sat, Jan 10, 2015 at 1:29 AM, Brian Norris <computersforpeace@gmail.com> wrote:
>> On Wed, Jan 07, 2015 at 10:37:20PM +0200, Andy Shevchenko wrote:
>>> We need to compare ret variable for negative value. The current code
>>> assigns the boolean to the ret and prints it wrongly in the warning
>>> message.
>>>
>>> Reported-by: Andrey Karpov <karpov@viva64.com>
>>> Cc: Giel van Schijndel <me@mortis.eu>
>>> Cc: Dimitri Gorokhovik <dimitri.gorokhovik@free.fr>
>>> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>>
>> To be clear, this touches some commented out code (yuck). I think you
>> noted this previously.
> 
> It had been proposed by Giel.

Yes, and I suspect (and hope) Brian's referring to the existence of
commented-out code as "yuck", not the removal of bugs from it.

>> For my reference, are you actually testing this driver?
> 
> Not a real testing. Only compilation on x86_32.

Combined with review I think that's enough given the nature of this
change.

-- 
Met vriendelijke groet,
With kind regards,
Giel van Schijndel

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]