Re: [PATCH 11/12] fs: don't reassign dirty inodes to default_backing_dev_info

Tejun Heo
2015-01-11T18:34:20Z

On Thu, Jan 08, 2015 at 06:45:32PM +0100, Christoph Hellwig wrote:
> If we have dirty inodes we need to call the filesystem for it, even if the
> device has been removed and the filesystem will error out early. The
> current code does that by reassining all dirty inodes to the default
> backing_dev_info when a bdi is unlinked, but that's pretty pointless given
> that the bdi must always outlive the super block.

It's also shifting writeback shutdown to destroy time from
unregistration time. This is part of fixing the bdi lifetime issue,
right? It hink It'd be worthwhile to mention that in the commit
message.

Other than that,

Reviewed-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun