Re: [PATCH v3 2/2] mtd: fsl-quadspi: Fix module unbound

[Brian Norris <computersforpeace@gmail.com>]

Hi Fabio,

On Tue, Jan 13, 2015 at 01:35:02PM -0200, Fabio Estevam wrote:
> On Fri, Jan 9, 2015 at 6:17 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> > OK, I still don't think you've got things right here.
> >
> > Are you testing this with a two-flash system? What sort of tests?
> 
> Yes, there are two qspi flashes on imx6sx-sdb board.
> 
> The test I do are:
> 
> - module unload/load - When I was adding dts support for imx6sx-sdb I
> would like to be able to load/unload the qspi driver. This is not
> possible currently, and this was the motivation for this series.

Right. So that's a good test.

> - Read the two flashes.

Are you doing any verification to make sure you're reading the *correct*
data? I'd imagine from some what I see in your patches, that you might
actually be reading from the wrong flash.

> root@freescale /$ dd if=/dev/mtd0 of=/dev/null bs=1M count=1
> 1+0 records in
> 1+0 records out
> 1048576 bytes (1.0MB) copied, 0.047851 seconds, 20.9MB/s
> 
> root@freescale /$ dd if=/dev/mtd1 of=/dev/null bs=1M count=1
> 1+0 records in
> 1+0 records out
> 1048576 bytes (1.0MB) copied, 0.052515 seconds, 19.0MB/s
> 
> Not sure what is the correct way to fix this though.

Brian