Re: [PATCH v3 2/2] mtd: fsl-quadspi: Fix module unbound

[Brian Norris <computersforpeace@gmail.com>]

Hi Fabio,

On Tue, Jan 13, 2015 at 07:45:22PM -0200, Fabio Estevam wrote:
> On Tue, Jan 13, 2015 at 4:51 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> 
> >> - Read the two flashes.
> >
> > Are you doing any verification to make sure you're reading the *correct*
> > data? I'd imagine from some what I see in your patches, that you might
> > actually be reading from the wrong flash.
> 
> Yes, you are right. Just confirmed that with this v3 applied I erased
> /dev/mtd0, but that also incorrectly erased /dev/mtd1.
> 
> Now I came back to the original v1 patch: isn't it the simpler
> approach for fixing the module load/unload crash problem?
> 
> It only keeps the mtd unregistration index in sync with registration
> and doesn't touch other areas of the driver.
> 
> IMHO it is an improvement over the current situation.

Right, I thought your original patch was an improvement, but it did
still leave some of the error path broken. And as Huang mentioned,
multiple devices were never actually *properly* supported, so there were
problems there.

> I agree that this driver needs more rework, but I am not able to put
> it on such good state.

I might be OK with taking v1 if we can do the following:

(1) Identify who will take responsibility for testing and improving this
driver. We might even add a MAINTAINERS entry

(2) Get an 'ack' from said person

(3) Document the known issues with this driver; add some TODO/FIXME
comments, and maybe disable potentially broken features until they get
fixed (e.g., only probe up to 1 flash, leaving the second flash
disabled)

Huang mentioned that Frank may be interested in (1).

Brian