From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YV1X4-00023K-36 for linux-mtd@lists.infradead.org; Mon, 09 Mar 2015 17:31:58 +0000 Received: by padet14 with SMTP id et14so77677011pad.0 for ; Mon, 09 Mar 2015 10:31:35 -0700 (PDT) Date: Mon, 9 Mar 2015 10:31:31 -0700 From: Brian Norris To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 3/3] mtd: nand: add NAND driver for Broadcom STB NAND controller Message-ID: <20150309173131.GT18140@ld-irv-0074> References: <1425691129-1150-1-git-send-email-computersforpeace@gmail.com> <1425691129-1150-4-git-send-email-computersforpeace@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Cc: "devicetree@vger.kernel.org" , Florian Fainelli , sbranden@broadcom.com, Corneliu Doban , Ray Jui , Kevin Cernekee , Linux Kernel Mailing List , Jonathan Richardson , Anatol Pomazao , bcm-kernel-feedback-list@broadcom.com, "linux-mtd@lists.infradead.org" , Dmitry Torokhov List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Mar 07, 2015 at 02:21:26PM +0100, Rafał Miłecki wrote: > On 7 March 2015 at 02:18, Brian Norris wrote: > > + /* NAND register range */ > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + ctrl->nand_base = devm_ioremap_resource(dev, res); > > + if (!ctrl->nand_base) > > + return -ENODEV; > > This is what I got during my first test: > brcmstb_nand 11315e0.nand: can't request region for resource [mem > 0x011315e0-0x011325df] > Unable to handle kernel paging request at virtual address fffffff0 > (not sure why yet). > > Hint: devm_ioremap_resource does never return NULL Thanks, fixed in 3 places. I expect you've figured out your problem here by now. Brian