From: Brian Norris <computersforpeace@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: devicetree@vger.kernel.org, "Rafał Miłecki" <zajec5@gmail.com>,
linux-mtd@lists.infradead.org,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>
Subject: Re: [PATCH 1/2] Documentation: devicetree: m25p80: add "nor-jedec" binding
Date: Wed, 11 Mar 2015 15:46:32 -0700 [thread overview]
Message-ID: <20150311224632.GD32500@ld-irv-0074> (raw)
In-Reply-To: <201503112322.46491.marex@denx.de>
On Wed, Mar 11, 2015 at 11:22:46PM +0100, Marek Vasut wrote:
> On Wednesday, March 11, 2015 at 10:57:25 PM, Brian Norris wrote:
> > Almost all flash that are "compatible" with m25p80 support the JEDEC
> > READ ID opcode (0x95)
>
> On the 2/2 patch, you claim READ ID is 0x9F . You might want to sort
> this inconsistency :) Otherwise ...
Ugh, it should be 0x9F of course. Thanks for noticing. I'll fix this
in the commit message and doc before applying, if I don't get other
complaints.
> Reviewed-by: Marek Vasut <marex@denx.de>
Thanks for the review!
Brian
next prev parent reply other threads:[~2015-03-11 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 21:57 [PATCH 1/2] Documentation: devicetree: m25p80: add "nor-jedec" binding Brian Norris
2015-03-11 21:57 ` [PATCH 2/2] mtd: m25p80: bind to "nor-jedec" ID, for auto-detection Brian Norris
2015-03-11 22:22 ` [PATCH 1/2] Documentation: devicetree: m25p80: add "nor-jedec" binding Marek Vasut
2015-03-11 22:46 ` Brian Norris [this message]
2015-03-12 10:19 ` Geert Uytterhoeven
2015-03-12 10:36 ` Rafał Miłecki
2015-03-12 10:40 ` Geert Uytterhoeven
2015-03-12 10:53 ` Mark Rutland
2015-03-20 19:02 ` Brian Norris
2015-03-12 10:58 ` Mark Rutland
2015-03-20 19:12 ` Brian Norris
2015-03-21 23:30 ` Rafał Miłecki
2015-03-25 0:55 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311224632.GD32500@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox