From: Brian Norris <computersforpeace@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] UBI: fix missing brace control flow
Date: Mon, 16 Mar 2015 11:08:44 -0700 [thread overview]
Message-ID: <20150316180844.GK32500@ld-irv-0074> (raw)
In-Reply-To: <54EB99F1.4040608@nod.at>
On Mon, Feb 23, 2015 at 10:21:53PM +0100, Richard Weinberger wrote:
> Am 23.02.2015 um 22:07 schrieb Brian Norris:
> > commit 0e707ae79ba3 ("UBI: do propagate positive error codes up") seems
> > to have produced an unintended change in the control flow here.
> >
> > Completely untested, but it looks obvious.
> >
> > Caught by Coverity, which didn't like the indentation. CID 1271184.
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > Cc: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Should go into 4.0, I expect.
>
> Good catch, patch tested and applied!
Is this going in 4.0? It fixes a typo in a hastily-applied patch that
made it to 4.0-rc1.
I'm also not sure I understand the role of the +linux-next and +master
branches in linux-ubifs.git. Typically 'next' means for the current+1
release (i.e., 4.1), while 'not-next' (i.e., your master branch?) would
be for the current release (4.0). But you have +master based on top of
+linux-next.
Brian
next prev parent reply other threads:[~2015-03-16 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 21:07 [PATCH] UBI: fix missing brace control flow Brian Norris
2015-02-23 21:21 ` Richard Weinberger
2015-03-16 18:08 ` Brian Norris [this message]
2015-03-16 18:21 ` Richard Weinberger
2015-03-17 9:08 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316180844.GK32500@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox