From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qg0-x22f.google.com ([2607:f8b0:400d:c04::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YY4nZ-0004ps-C6 for linux-mtd@lists.infradead.org; Wed, 18 Mar 2015 03:37:38 +0000 Received: by qgf3 with SMTP id 3so27069115qgf.3 for ; Tue, 17 Mar 2015 20:37:15 -0700 (PDT) Sender: Taesoo Kim Date: Tue, 17 Mar 2015 23:37:12 -0400 From: Taesoo Kim To: Brian Norris Subject: Re: [PATCH 1/1] UBIFS: fix incorrect unlocking handling Message-ID: <20150318033712.GE29195@taesoo.org> References: <1426644566-29754-1-git-send-email-tsgatesv@gmail.com> <20150318031858.GO32500@ld-irv-0074> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150318031858.GO32500@ld-irv-0074> Cc: Subodh Nijsure , dedekind1@gmail.com, Ben Shelton , sanidhya@gatech.edu, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, Terry Wilcox , linux-mtd@lists.infradead.org, blee@gatech.edu, Taesoo Kim , Marc Kleine-Budde , Gratian Crisan , csong84@gatech.edu, changwoo@gatech.edu, Brad Mouring List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Yes. The last commit that modifies 'ubifs/dir.c' (sorry for missing the context). All error handling routines introduced by 'd7f0b70d30ffb9bbe6b8a3e1035cf0b79965ef53' 1) incorrectly 'unlock' and 2) incorrectly restore 'i_size'. Thanks, Taesoo On 03/17/15 at 08:18pm, Brian Norris wrote: > On Tue, Mar 17, 2015 at 10:09:26PM -0400, Taesoo Kim wrote: > > When ubifs_init_security() fails, 'ui_mutex' is incorrectly > > unlocked and incorrectly restores 'i_size'. There are four > > such places that were introduce by the last commit. > > "The last commit" is not very descriptive. Are you speaking of this > commit? > > commit d7f0b70d30ffb9bbe6b8a3e1035cf0b79965ef53 > Author: Subodh Nijsure > Date: Fri Oct 31 13:50:30 2014 -0500 > > UBIFS: Add security.* XATTR support for the UBIFS > > CC'ing authors/reviewers. > > Brian > > > Signed-off-by: Taesoo Kim > > --- > > fs/ubifs/dir.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c > > index 0fa6c80..5b24bc4 100644 > > --- a/fs/ubifs/dir.c > > +++ b/fs/ubifs/dir.c > > @@ -272,7 +272,7 @@ static int ubifs_create(struct inode *dir, struct dentry *dentry, umode_t mode, > > > > err = ubifs_init_security(dir, inode, &dentry->d_name); > > if (err) > > - goto out_cancel; > > + goto out_inode; > > > > mutex_lock(&dir_ui->ui_mutex); > > dir->i_size += sz_change; > > @@ -292,6 +292,7 @@ out_cancel: > > dir->i_size -= sz_change; > > dir_ui->ui_size = dir->i_size; > > mutex_unlock(&dir_ui->ui_mutex); > > +out_inode: > > make_bad_inode(inode); > > iput(inode); > > out_budg: > > @@ -732,7 +733,7 @@ static int ubifs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) > > > > err = ubifs_init_security(dir, inode, &dentry->d_name); > > if (err) > > - goto out_cancel; > > + goto out_inode; > > > > mutex_lock(&dir_ui->ui_mutex); > > insert_inode_hash(inode); > > @@ -757,6 +758,7 @@ out_cancel: > > dir_ui->ui_size = dir->i_size; > > drop_nlink(dir); > > mutex_unlock(&dir_ui->ui_mutex); > > +out_inode: > > make_bad_inode(inode); > > iput(inode); > > out_budg: > > @@ -816,7 +818,7 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry, > > > > err = ubifs_init_security(dir, inode, &dentry->d_name); > > if (err) > > - goto out_cancel; > > + goto out_inode; > > > > mutex_lock(&dir_ui->ui_mutex); > > dir->i_size += sz_change; > > @@ -836,6 +838,7 @@ out_cancel: > > dir->i_size -= sz_change; > > dir_ui->ui_size = dir->i_size; > > mutex_unlock(&dir_ui->ui_mutex); > > +out_inode: > > make_bad_inode(inode); > > iput(inode); > > out_budg: > > @@ -896,7 +899,7 @@ static int ubifs_symlink(struct inode *dir, struct dentry *dentry, > > > > err = ubifs_init_security(dir, inode, &dentry->d_name); > > if (err) > > - goto out_cancel; > > + goto out_inode; > > > > mutex_lock(&dir_ui->ui_mutex); > > dir->i_size += sz_change; > > -- > > 2.3.3 > >