From: Ben Shelton <ben.shelton@ni.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org,
Jeff Westfahl <jeff.westfahl@ni.com>
Subject: Re: [PATCH] mtd: Introduce CONFIG_MTD_RESERVE_END
Date: Thu, 30 Apr 2015 17:46:35 -0500 [thread overview]
Message-ID: <20150430224635.GA18985@bshelton-desktop> (raw)
In-Reply-To: <1430431357.2187.43.camel@x220>
Hi Paul,
On 05/01, Paul Bolle wrote:
> While you're discussing more substantial questions with Brian, I found
> some nits.
>
> On Wed, 2015-04-29 at 14:28 -0500, Ben Shelton wrote:
> > --- a/drivers/mtd/Kconfig
> > +++ b/drivers/mtd/Kconfig
>
>
> > +config MTD_RESERVE_END
> > + int "Reserved space at the end of an all remaining space partition"
> > + depends on MTD_CMDLINE_PARTS = "y"
>
> (The quotes are unneeded.)
>
> MTD_CMDLINE_PARTS is tristate. Why does it need to be built-in for this
> symbol?
Good catch -- MTD_RESERVE_END should apply whether MTD_CMDLINE_PARTS is
built-in or a module. I'll fix that in the next version of the patch.
Thanks,
Ben
prev parent reply other threads:[~2015-04-30 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 19:28 [PATCH] mtd: Introduce CONFIG_MTD_RESERVE_END Ben Shelton
2015-04-29 21:46 ` Brian Norris
2015-04-30 17:36 ` Ben Shelton
2015-05-01 11:57 ` Jonas Gorski
2015-05-07 3:27 ` Brian Norris
2015-04-30 22:02 ` Paul Bolle
2015-04-30 22:46 ` Ben Shelton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430224635.GA18985@bshelton-desktop \
--to=ben.shelton@ni.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jeff.westfahl@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox