Re: [PATCH 1/3] mtd: nand: Add on-die ECC support

Paul Bolle
2015-03-25T20:39:58Z

Probably not really the feedback you're hoping for at this moment, this
being an RFC, but I spotted two nits anyway.

On Wed, 2015-03-25 at 15:02 +0100, Richard Weinberger wrote:
> --- /dev/null
> +++ b/drivers/mtd/nand/nand_ondie.c

This file makes git am whine: "new blank line at EOF".

> +#include <linux/types.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>

Is this include needed? The code can only be built in. This files also
builds silently without that include. I used the rather hacky
make EXTRA_CFLAGS="-DCONFIG_MTD_NAND_ECC_ON_DIE" drivers/mtd/nand/nand_ondie.o

to test the build.

> +#include <linux/slab.h>
> +#include <linux/bitops.h>
> +#include <linux/mtd/mtd.h>
> +#include <linux/mtd/nand.h>
> +#include <linux/mtd/nand_ondie.h>

Paul Bolle