From: Brian Norris <computersforpeace@gmail.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com,
rjui@broadcom.com, zajec5@gmail.com,
linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 1/7] mtd: brcmnand: remove double new line from print
Date: Mon, 18 May 2015 11:09:59 -0700 [thread overview]
Message-ID: <20150518180959.GP11598@ld-irv-0074> (raw)
In-Reply-To: <1431877266-28566-2-git-send-email-hauke@hauke-m.de>
On Sun, May 17, 2015 at 05:41:00PM +0200, Hauke Mehrtens wrote:
> The caller already adds a new line and in the other cases there is no
> new line added.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/mtd/nand/brcmnand/brcmnand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
> index a780768..bae30ab 100644
> --- a/drivers/mtd/nand/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
> @@ -1765,7 +1765,7 @@ static void brcmnand_print_cfg(char *buf, struct brcmnand_cfg *cfg)
> else if (cfg->sector_size_1k)
> sprintf(buf, ", BCH-%u (1KiB sector)", cfg->ecc_level << 1);
> else
> - sprintf(buf, ", BCH-%u\n", cfg->ecc_level);
> + sprintf(buf, ", BCH-%u", cfg->ecc_level);
> }
>
> /*
Good catch. Applied to l2-mtd.git.
next prev parent reply other threads:[~2015-05-18 18:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 15:40 [PATCH 0/7] mtd: brcmnand: add support for NAND core on bcma bus Hauke Mehrtens
2015-05-17 15:41 ` [PATCH 1/7] mtd: brcmnand: remove double new line from print Hauke Mehrtens
2015-05-18 18:09 ` Brian Norris [this message]
2015-05-17 15:41 ` [PATCH 2/7] mtd: brcmnand: do not make local variable static Hauke Mehrtens
2015-05-18 18:13 ` Brian Norris
2015-05-17 15:41 ` [PATCH 3/7] mtd: brcmnand: use struct device and not platform_device Hauke Mehrtens
2015-05-17 15:41 ` [PATCH 4/7] mtd: brcmnand: add methods to register struct device Hauke Mehrtens
2015-05-17 15:41 ` [PATCH 5/7] mtd: brcmnand: add bcma driver Hauke Mehrtens
2015-05-20 0:34 ` Brian Norris
2015-05-20 6:39 ` Rafał Miłecki
2015-05-20 18:40 ` Brian Norris
2015-05-20 22:10 ` Hauke Mehrtens
2015-05-20 22:48 ` Ray Jui
2015-05-21 7:51 ` Rafał Miłecki
2015-05-27 0:18 ` Brian Norris
2015-05-27 22:18 ` Hauke Mehrtens
2015-05-17 15:41 ` [PATCH 6/7] mtd: brcmnand: run bcm47xxpart part parser in addition Hauke Mehrtens
2015-05-17 16:05 ` Jonas Gorski
2015-05-17 16:14 ` Hauke Mehrtens
2015-05-17 15:41 ` [PATCH 7/7] ARM: BCM5301X: add NAND flash chip description Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518180959.GP11598@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=linux-mtd@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox