Re: [PATCH 1/1] mtd: add support for typed parsers splitting partitions

[Brian Norris <computersforpeace@gmail.com>]

I haven't reviewed this entirely yet, but my build tests complained:

On Mon, May 18, 2015 at 02:34:53PM +0200, Rafał Miłecki wrote:
> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> index cafdb88..d583d6d 100644
> --- a/drivers/mtd/mtdpart.c
> +++ b/drivers/mtd/mtdpart.c
[...]
> @@ -775,6 +781,72 @@ int parse_mtd_partitions(struct mtd_info *master, const char *const *types,
>  	return ret;
>  }
>  
> +int mtd_parse_typed_partitions(struct mtd_info *slave,
> +			       enum mtd_partition_type type,
> +			       struct mtd_partition **pparts,
> +			       struct mtd_part_parser_data *data)

drivers/mtd/mtdpart.c:784:5: warning: no previous prototype for ‘mtd_parse_typed_partitions’ [-Wmissing-prototypes]
 int mtd_parse_typed_partitions(struct mtd_info *slave,
     ^
drivers/mtd/mtdpart.c:784:5: warning: symbol 'mtd_parse_typed_partitions' was not declared. Should it be static? [sparse]

> +{
> +	struct mtd_part_parser *p = NULL;
> +	bool found;
> +	int ret = 0;
> +
> +	while (1) {

[...]

Brian