Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Marek Vasut" <marex@denx.de>,
	"Michal Suchanek" <hramrach@gmail.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"grmoore@altera.com" <grmoore@altera.com>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Ben Hutchings" <ben@decadent.org.uk>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Huang Shijie" <b32955@freescale.com>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org,
	"Kumar Gala" <galak@codeaurora.org>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Alison Chaiken" <alison_chaiken@mentor.com>,
	devicetree <devicetree@vger.kernel.org>,
	"Bean Huo 霍斌斌 (beanhuo)" <beanhuo@micron.com>
Subject: Re: [linux-sunxi] [PATCH 3/3] MTD: m25p80: Add option to limit SPI transfer size.
Date: Wed, 20 May 2015 16:27:59 -0700	[thread overview]
Message-ID: <20150520232759.GW11598@ld-irv-0074> (raw)
In-Reply-To: <CAGRGNgXKrpJ8rc4h4BykgHsn3kfT5fuAssMK1bQJtxhVL=s2BA@mail.gmail.com>

On Fri, May 01, 2015 at 12:58:52AM +1000, Julian Calaby wrote:
> On Thu, Apr 30, 2015 at 11:46 PM, Michal Suchanek <hramrach@gmail.com> wrote:
> > My SPI driver does not support DMA so sizes larger than 64 bytes return
> > an error. Add an option to limit transfer size so m25p80 can be used
> > with reduced speed with such controller.
> 
> I suspect that this will be rejected as the maximum transfer size is a
> property of the SPI controller, not the device and should be exported
> to the device driver from the controller, not specified in the
> device's binding.

Absolutely correct. This does not belong in the device tree.

Brian

  reply	other threads:[~2015-05-20 23:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 14:22 [PATCH 0/3] Using SPI NOR flah on sunxi Michal Suchanek
2015-04-30 13:33 ` [PATCH 1/3] MTD: m25p80: fix write return value Michal Suchanek
2015-04-30 18:43   ` Marek Vasut
2015-04-30 21:37     ` Michal Suchanek
2015-04-30 13:38 ` [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write Michal Suchanek
2015-05-20 23:38   ` Brian Norris
2015-05-21  8:39     ` Michal Suchanek
2015-05-21 10:28       ` Mark Brown
2015-05-22  7:17         ` Brian Norris
2015-05-22  7:25           ` Brian Norris
2015-05-22  9:37             ` Mark Brown
2015-04-30 13:46 ` [PATCH 3/3] MTD: m25p80: Add option to limit SPI transfer size Michal Suchanek
2015-04-30 14:58   ` [linux-sunxi] " Julian Calaby
2015-05-20 23:27     ` Brian Norris [this message]
2015-04-30 16:30 ` [PATCH 0/3] Using SPI NOR flah on sunxi Thomas.Betker
2015-04-30 16:56   ` Michal Suchanek
2015-04-30 18:34     ` Marek Vasut
2015-05-20 23:54       ` Brian Norris
     [not found] ` <jwv4mnwfppf.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>
2015-05-04 10:32   ` [linux-sunxi] " Michal Suchanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520232759.GW11598@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=alison_chaiken@mentor.com \
    --cc=b32955@freescale.com \
    --cc=beanhuo@micron.com \
    --cc=ben@decadent.org.uk \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=galak@codeaurora.org \
    --cc=grmoore@altera.com \
    --cc=hramrach@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=julian.calaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=marex@denx.de \
    --cc=mark.rutland@arm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox