From: Brian Norris <computersforpeace@gmail.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com,
rjui@broadcom.com, zajec5@gmail.com, jogo@openwrt.org,
linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [RFC] ARM: BCM5301X: add NAND flash chip description
Date: Tue, 26 May 2015 18:15:38 -0700 [thread overview]
Message-ID: <20150527011538.GE27753@ld-irv-0074> (raw)
In-Reply-To: <20150527004144.GC27753@ld-irv-0074>
On Tue, May 26, 2015 at 05:41:44PM -0700, Brian Norris wrote:
> > + linux,part-probe = "ofpart", "bcm47xxpart";
>
> ^ NAK to this line. You still haven't documented any semantics for this
> property. And I gave you several comments on your previous patch about
> what would need to change before I'd accept this property.
Just noticed you sent v2 of your previous patch over the weekend, which
does include documentation for this. That's a start, but I'm still not
very happy with the property. I'll put my full comments there
eventually.
Brian
next prev parent reply other threads:[~2015-05-27 1:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-24 18:32 [RFC] ARM: BCM5301X: add NAND flash chip description Hauke Mehrtens
2015-05-26 20:20 ` Rafał Miłecki
2015-05-26 20:53 ` nick
2015-05-27 0:41 ` Brian Norris
2015-05-27 1:15 ` Brian Norris [this message]
2015-05-27 22:04 ` Hauke Mehrtens
2015-05-27 7:37 ` Arnd Bergmann
2015-05-27 21:46 ` Hauke Mehrtens
2015-05-27 21:57 ` Brian Norris
2015-05-28 8:21 ` Arnd Bergmann
2015-05-29 15:29 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527011538.GE27753@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=jogo@openwrt.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox