From: Brian Norris <computersforpeace@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: David Woodhouse <dwmw2@infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Wenlin Kang <wenlin.kang@windriver.com>
Subject: Re: [PATCH] mtd: blktrans: use better error code for unimplemented ioctl()
Date: Wed, 27 May 2015 12:15:21 -0700 [thread overview]
Message-ID: <20150527191429.GF27753@ld-irv-0074> (raw)
In-Reply-To: <20150521175431.GC11598@ld-irv-0074>
On Thu, May 21, 2015 at 10:54:31AM -0700, Brian Norris wrote:
> In commit 50183936254b ("mtd: blktrans: change blktrans_getgeo return
> value") we fixed the problem that ioctl(HDIO_GETGEO) might return 0
> (success) for mtdblock devices which did not implement the feature and
> would leave a blank (zero) result.
>
> But now, let's get the error code right. Other code paths on this ioctl
> tend to use -ENOTTY to notify the user that the ioctl() is not supported
> for the device, so let's use that instead of -EOPNOTSUPP.
>
> Suggested-by: Richard Weinberger <richard@nod.at>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> Against l2-mtd.git (linux-next)
Applied.
prev parent reply other threads:[~2015-05-27 19:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 6:29 [PATCH] mtd: blktrans: change blktrans_getgeo rerurn value Wenlin Kang
2015-05-20 19:33 ` Brian Norris
2015-05-20 19:47 ` nick
2015-05-21 6:49 ` Wenlin Kang
2015-05-21 7:37 ` Brian Norris
2015-05-21 8:01 ` Wenlin Kang
2015-05-21 7:56 ` Richard Weinberger
2015-05-21 8:05 ` Brian Norris
2015-05-21 8:22 ` Wenlin Kang
2015-05-21 10:17 ` Richard Weinberger
2015-05-21 17:54 ` [PATCH] mtd: blktrans: use better error code for unimplemented ioctl() Brian Norris
2015-05-27 19:15 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527191429.GF27753@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=wenlin.kang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox