Re: [PATCH V3] mtd: fsl-quadspi: Access multiple chips simultaneously

[Brian Norris <computersforpeace@gmail.com>]

Hi Han,

On Wed, May 20, 2015 at 05:28:20PM -0500, Han Xu wrote:
> On Wed, May 20, 2015 at 4:52 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> > On Wed, May 13, 2015 at 02:40:57PM -0500, Han Xu wrote:
> >> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> >> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> > ...
> >> @@ -761,13 +763,17 @@ static int fsl_qspi_prep(struct spi_nor *nor, enum spi_nor_ops ops)
> >>       struct fsl_qspi *q = nor->priv;
> >>       int ret;
> >>
> >> +     mutex_lock(&q->lock);
> >>       ret = clk_enable(q->clk_en);
> >> -     if (ret)
> >> +     if (ret) {
> >> +             mutex_unlock(&q->lock);
> >>               return ret;
> >> +     }
> >>
> >>       ret = clk_enable(q->clk);
> >>       if (ret) {
> >>               clk_disable(q->clk_en);
> >> +             mutex_unlock(&q->lock);
> >>               return ret;
> >>       }
> >>
> >
> > I think it'd be better to have a single error path in this function now.
> >
> > Otherwise, I think this is OK. I can push the appended patch instead, if
> > that's OK with you.
> 
> Hi Brian, I think that's fine. I will submit another patch to improve it.

OK. Resubmit if you'd like, or just ack my version. I'd like your
Tested-by if possible.

> >
> > Signed-off-by: Han Xu <b45815@freescale.com>
> > [Brian: reworked err path in fsl_qspi_prep()]
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > ---
> >  drivers/mtd/spi-nor/fsl-quadspi.c | 32 +++++++++++++++++++++++---------
> >  1 file changed, 23 insertions(+), 9 deletions(-)
[...]

Brian