public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Roy Spliet <r.spliet@ultimaker.com>
Cc: Richard Weinberger <richard@nod.at>,
	Linux-sunxi <linux-sunxi@googlegroups.com>,
	Linux MTD <linux-mtd@lists.infradead.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RFC] Add DMA RX support for sunxi nand
Date: Sun, 14 Jun 2015 10:51:59 +0200	[thread overview]
Message-ID: <20150614105159.78859b36@bbrezillon> (raw)
In-Reply-To: <1434109129-28183-1-git-send-email-r.spliet@ultimaker.com>

Hi Roy,

Adding Richard in CC since he was part of the discussion we had on #mtd
about DMA and UBI/UBIFS. 

On Fri, 12 Jun 2015 13:38:47 +0200
Roy Spliet <r.spliet@ultimaker.com> wrote:

> Following are two patches for sunxi nand DMA support. There's a whole phletora
> of reasons why these are marked RFC, including:
> - Sunxi DMA support still needs to be merged upstream
> - Sun7i NAND definitions are not merged upstream
> - No TX support
> - Bounce buffer size is fixed to 8KB, and I have no idea whether this is sane

Here is a patch [1] which should help in creating an sg_table from a
buffer (even if this buffer was allocated with vmalloc), and thus
avoid using this bounce buffer when possible.
I also patched the GPMI driver [2] to use these helpers functions
instead of manually testing the buffer validity.

This is still an early version (note that it hasn't been tested yet),
but IMHO, we should add some consistency in all those NAND drivers which
are pretty much all doing the same kind of tests (when they are not
doing it wrong).

Best Regards,

Boris

[1]http://code.bulix.org/jl997t-88538
[2]http://code.bulix.org/sexjf4-88539

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      parent reply	other threads:[~2015-06-14  8:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12 11:38 [RFC] Add DMA RX support for sunxi nand Roy Spliet
2015-06-12 11:38 ` [RFC 1/2] mtd: nand: sunxi: Add RX DMA support Roy Spliet
2015-06-12 11:38 ` [RFC 2/2] dts: Add Sun7i NAND DMA definitions Roy Spliet
2015-06-13  6:08 ` [RFC] Add DMA RX support for sunxi nand Boris Brezillon
2015-06-14  8:51 ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150614105159.78859b36@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=r.spliet@ultimaker.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox