linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Sheng Yong <shengyong1@huawei.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org, richard@nod.at
Subject: Re: [PATCH 0/2] mtd: nandsim: fix error handling
Date: Tue, 23 Jun 2015 14:59:17 -0700	[thread overview]
Message-ID: <20150623215917.GP4917@ld-irv-0074> (raw)
In-Reply-To: <1434530713-81591-1-git-send-email-shengyong1@huawei.com>

On Wed, Jun 17, 2015 at 08:45:11AM +0000, Sheng Yong wrote:
> These 2 patches fix error handling when nandsim initialization fails.
> 
> In alloc_device(), if creating slab memory fails, free_device() will try
> to destroy the slab memory without checking if it exists.  PATCH 1 fixes
> it.
> 
> If something goes wrong in init_nandsim(), it calls free_device() before
> returning. However, the caller of init_nandsim() - ns_init_module() - also
> does the cleanup by calling free_nandsim(). This causes double free. PATCH
> 2 fixes it.
> 
> Thanks,
> Sheng
> 
> Sheng Yong (2):
>   mtd: nandsim: fix free of NULL pointer
>   mtd: nandsim: fix double free
> 
>  drivers/mtd/nand/nandsim.c | 22 +++++++---------------
>  1 file changed, 7 insertions(+), 15 deletions(-)

This series doesn't apply cleanly to -next. Please rebase on either
linux-next.git or l2-mtd.git:

http://www.linux-mtd.infradead.org/source.html

Thanks,
Brian

      parent reply	other threads:[~2015-06-23 21:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17  8:45 [PATCH 0/2] mtd: nandsim: fix error handling Sheng Yong
2015-06-17  8:45 ` [PATCH 1/2] mtd: nandsim: fix free of NULL pointer Sheng Yong
2015-06-17  8:48   ` Richard Weinberger
2015-06-17  9:00     ` Richard Weinberger
2015-06-17  9:03     ` Sheng Yong
2015-06-17  9:05       ` Richard Weinberger
2015-06-17  8:45 ` [PATCH 2/2] mtd: nandsim: fix double free Sheng Yong
2015-06-23  1:03 ` [PATCH 0/2] mtd: nandsim: fix error handling Sheng Yong
2015-06-23  6:26   ` Richard Weinberger
2015-06-24  0:53     ` Sheng Yong
2015-06-23 21:59 ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150623215917.GP4917@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=shengyong1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).