public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: fangwei <fangwei1@huawei.com>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] jffs2: remove unneeded kfree.
Date: Mon, 6 Jul 2015 15:23:18 -0700	[thread overview]
Message-ID: <20150706222318.GB18370@brian-ubuntu> (raw)
In-Reply-To: <55239023.5000107@huawei.com>

On Tue, Apr 07, 2015 at 04:06:59PM +0800, fangwei wrote:
> c->oobbuf hasn't been kmalloced in jffs2_dataflash_setup, so
> there is no need to free it.
> 
> Signed-off-by: Wei Fang <fangwei1@huawei.com>
> ---
>  fs/jffs2/wbuf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/jffs2/wbuf.c b/fs/jffs2/wbuf.c
> index 09ed551..63f31c0 100644
> --- a/fs/jffs2/wbuf.c
> +++ b/fs/jffs2/wbuf.c
> @@ -1274,7 +1274,6 @@ int jffs2_dataflash_setup(struct jffs2_sb_info *c) {
>  #ifdef CONFIG_JFFS2_FS_WBUF_VERIFY
>         c->wbuf_verify = kmalloc(c->wbuf_pagesize, GFP_KERNEL);
>         if (!c->wbuf_verify) {
> -               kfree(c->oobbuf);
>                 kfree(c->wbuf);
>                 return -ENOMEM;
>         }

Your patches are whitespace damaged and cannot be applied. Please fix
your mailer and resend. Consider retesting by sending to yourself and
try using git-am. If all else fails, git-send-email is your friend.

Thanks,
Brian

  reply	other threads:[~2015-07-06 22:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07  8:06 [PATCH] jffs2: remove unneeded kfree fangwei
2015-07-06 22:23 ` Brian Norris [this message]
2015-07-07  1:43   ` Wei Fang
  -- strict thread matches above, loose matches on Subject: below --
2015-06-25  7:29 Wei Fang
2015-07-06 22:27 ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150706222318.GB18370@brian-ubuntu \
    --to=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=fangwei1@huawei.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox