From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 25 Jul 2015 11:30:36 +0800 From: Shawn Guo To: Stefan Agner Cc: dwmw2@infradead.org, computersforpeace@gmail.com, mark.rutland@arm.com, boris.brezillon@free-electrons.com, aaron@tastycactus.com, marb@ixxat.de, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, bpringlemeir@gmail.com, linux-kernel@vger.kernel.org, sebastian@breakpoint.cc, robh+dt@kernel.org, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, galak@codeaurora.org, shawn.guo@linaro.org, devicetree@vger.kernel.org, Bill Pringlemeir Subject: Re: [PATCH v7 4/5] ARM: dts: vf610twr: add NAND flash controller peripherial Message-ID: <20150725033036.GI12927@tiger> References: <1437743784-30163-1-git-send-email-stefan@agner.ch> <1437743784-30163-5-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437743784-30163-5-git-send-email-stefan@agner.ch> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Jul 24, 2015 at 03:16:23PM +0200, Stefan Agner wrote: > This adds the NAND flash controller (NFC) peripherial. The driver > supports the SLC NAND chips found on Freescale's Vybrid Tower System > Module. The Micron NAND chip on the module needs 4-bit ECC per 512 > byte page. Use 24-bit ECC per 2k page, which is supported by the > driver. > > Signed-off-by: Bill Pringlemeir > Signed-off-by: Stefan Agner > --- > arch/arm/boot/dts/vf610-twr.dts | 44 +++++++++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/vfxxx.dtsi | 8 ++++++++ > 2 files changed, 52 insertions(+) > > diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts > index 375ab23..0b2b932 100644 > --- a/arch/arm/boot/dts/vf610-twr.dts > +++ b/arch/arm/boot/dts/vf610-twr.dts > @@ -287,6 +287,50 @@ > status = "okay"; > }; > > +&iomuxc { > + vf610-twr { > + pinctrl_nfc_1: nfcgrp_1 { The suffix "_1" is meaningless. Please drop it here as well as patch #5. Shawn > + fsl,pins = < > + VF610_PAD_PTD31__NF_IO15 0x28df > + VF610_PAD_PTD30__NF_IO14 0x28df > + VF610_PAD_PTD29__NF_IO13 0x28df > + VF610_PAD_PTD28__NF_IO12 0x28df > + VF610_PAD_PTD27__NF_IO11 0x28df > + VF610_PAD_PTD26__NF_IO10 0x28df > + VF610_PAD_PTD25__NF_IO9 0x28df > + VF610_PAD_PTD24__NF_IO8 0x28df > + VF610_PAD_PTD23__NF_IO7 0x28df > + VF610_PAD_PTD22__NF_IO6 0x28df > + VF610_PAD_PTD21__NF_IO5 0x28df > + VF610_PAD_PTD20__NF_IO4 0x28df > + VF610_PAD_PTD19__NF_IO3 0x28df > + VF610_PAD_PTD18__NF_IO2 0x28df > + VF610_PAD_PTD17__NF_IO1 0x28df > + VF610_PAD_PTD16__NF_IO0 0x28df > + VF610_PAD_PTB24__NF_WE_B 0x28c2 > + VF610_PAD_PTB25__NF_CE0_B 0x28c2 > + VF610_PAD_PTB27__NF_RE_B 0x28c2 > + VF610_PAD_PTC26__NF_RB_B 0x283d > + VF610_PAD_PTC27__NF_ALE 0x28c2 > + VF610_PAD_PTC28__NF_CLE 0x28c2 > + >; > + }; > + }; > +}; > + > +&nfc { > + assigned-clocks = <&clks VF610_CLK_NFC>; > + assigned-clock-rates = <33000000>; > + nand-bus-width = <16>; > + nand-ecc-mode = "hw"; > + nand-ecc-step-size = <2048>; > + nand-ecc-strength = <24>; > + nand-on-flash-bbt; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_nfc_1>; > + status = "okay"; > +}; > + > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart1>; > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > index 4aa3351..2f4b04d 100644 > --- a/arch/arm/boot/dts/vfxxx.dtsi > +++ b/arch/arm/boot/dts/vfxxx.dtsi > @@ -520,6 +520,14 @@ > status = "disabled"; > }; > > + nfc: nand@400e0000 { > + compatible = "fsl,vf610-nfc"; > + reg = <0x400e0000 0x4000>; > + interrupts = <83 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks VF610_CLK_NFC>; > + clock-names = "nfc"; > + status = "disabled"; > + }; > }; > }; > }; > -- > 2.4.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >