From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from ipmail06.adl2.internode.on.net ([150.101.137.129])
 by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux))
 id 1ZM6uU-0000bh-8V
 for linux-mtd@lists.infradead.org; Mon, 03 Aug 2015 03:59:35 +0000
Date: Mon, 3 Aug 2015 13:59:09 +1000
From: Dave Chinner <david@fromorbit.com>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Cc: eguan@redhat.com, fstests@vger.kernel.org, dedekind1@gmail.com,
 richard.weinberger@gmail.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/5] xfstest: generic/219 add _require_odirect
Message-ID: <20150803035909.GP3902@dastard>
References: <1438236417-24612-1-git-send-email-yangds.fnst@cn.fujitsu.com>
 <1438236417-24612-3-git-send-email-yangds.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438236417-24612-3-git-send-email-yangds.fnst@cn.fujitsu.com>
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Thu, Jul 30, 2015 at 02:06:54PM +0800, Dongsheng Yang wrote:
> generic/219 is testing quota in three use cases including
> Direct I/O. So we have to add a dependence to odirect in
> this test.

Hmmm - you've modified on only 2 tests here in this patch series
that use direct IO. There are many more - just looking for direct IO
comments, these generic tests use direct IO in some way, and there
are others that such usage is not obvious (e.g. this patch to
generic/219):

generic/091
generic/113
generic/130
generic/214
generic/224
generic/263
shared/272

And all the aio/dio tests:

generic/036
generic/198
generic/207
generic/208
generic/209
generic/210
generic/211
generic/212
generic/239
generic/240
generic/323

And there are others that run fio that uses DIO, too, like

generic/299
generic/300

And so on. I haven't even looked at all the fsx tests that might
use DIO, and I know that some of them are not listed above...

On the whole, I think ubifs would be better to implement DIO via
buffered fallback that to make us have to annotate every test that
uses DIO in some way...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com