Re: [PATCH 1/2] nand: pxa3xx: Increase READ_ID buffer and make the size static

[Brian Norris <computersforpeace@gmail.com>]

On Mon, Aug 03, 2015 at 11:31:25AM -0300, Ezequiel Garcia wrote:
> The read ID count should be made as large as the maximum READ_ID size,
> so there's no need to have dynamic size. This commit sets the hardware
> maximum read ID count, which should be more than enough on all cases.
> Also, we get rid of the read_id_bytes, and use a macro instead.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
>  drivers/mtd/nand/pxa3xx_nand.c | 28 ++++++----------------------
>  1 file changed, 6 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
> index 1259cc5..0815f11 100644
> --- a/drivers/mtd/nand/pxa3xx_nand.c
> +++ b/drivers/mtd/nand/pxa3xx_nand.c
> @@ -126,6 +126,8 @@
>  #define EXT_CMD_TYPE_LAST_RW	1 /* Last naked read/write */
>  #define EXT_CMD_TYPE_MONO	0 /* Monolithic read/write */
>  
> +#define READ_ID_BYTES		7 /* Large enough to read 'JEDEC' */
> +

For the future: nand_base likes to read 8 bytes of ID for
regular ID decoding. But pxa3xx_nand doesn't use the standard ID code
still, so that's not a problem yet.

Brian