public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: han.xu@freescale.com, linux-mtd@lists.infradead.org,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Huang Shijie <shijie.huang@intel.com>
Subject: Re: [PATCH] spi-nor: Kconfig: Remove unneeded help message
Date: Wed, 12 Aug 2015 20:12:39 -0700	[thread overview]
Message-ID: <20150813031239.GF108786@google.com> (raw)
In-Reply-To: <1439378899-5660-1-git-send-email-festevam@gmail.com>

On Wed, Aug 12, 2015 at 08:28:19AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> The "We only connect the NOR to this controller now" phrase
> is not really useful for a Kconfig help text, so remove it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/mtd/spi-nor/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index 64a4f0e..baa8442 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -26,6 +26,5 @@ config SPI_FSL_QUADSPI
>  	depends on ARCH_MXC
>  	help
>  	  This enables support for the Quad SPI controller in master mode.
> -	  We only connect the NOR to this controller now.

I'm inclined to accept this patch, but I'm curious what the intention
for the original statement was. Does this mean "this controller could
support generic SPI, but this driver only bothers to implement the NOR
flash protocol"?

>  
>  endif # MTD_SPI_NOR
> -- 
> 1.9.1
> 

Brian

  reply	other threads:[~2015-08-13  3:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 11:28 [PATCH] spi-nor: Kconfig: Remove unneeded help message Fabio Estevam
2015-08-13  3:12 ` Brian Norris [this message]
2015-08-13 16:49   ` Li Frank
2015-08-13 17:05     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150813031239.GF108786@google.com \
    --to=computersforpeace@gmail.com \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=han.xu@freescale.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shijie.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox