linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Alexis Ballier <aballier@gentoo.org>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Huang Shijie" <shijie.huang@intel.com>,
	"Gabor Juhos" <juhosg@openwrt.org>,
	"Ben Hutchings" <ben@decadent.org.uk>,
	"Bean Huo 霍斌斌 (beanhuo)" <beanhuo@micron.com>,
	"open list:MEMORY TECHNOLOGY DEVICES (MTD)"
	<linux-mtd@lists.infradead.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: Add support for sst25wf020a.
Date: Fri, 14 Aug 2015 22:45:14 +0200	[thread overview]
Message-ID: <201508142245.14289.marex@denx.de> (raw)
In-Reply-To: <1439573741-24491-1-git-send-email-aballier@gentoo.org>

On Friday, August 14, 2015 at 07:35:39 PM, Alexis Ballier wrote:
> It is a 256KiB flash with 4 KiB erase sectors
> and 64KiB overlay blocks.
> 
> This is the one available on Hardkernel's Odroid U3 shield.
> 
> Signed-off-by: Alexis Ballier <aballier@gentoo.org>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index d78831b..e521b35 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -636,6 +636,7 @@ static const struct spi_device_id spi_nor_ids[] = {
>  	{ "sst25wf512",  INFO(0xbf2501, 0, 64 * 1024,  1, SECT_4K | SST_WRITE) 
},
>  	{ "sst25wf010",  INFO(0xbf2502, 0, 64 * 1024,  2, SECT_4K | SST_WRITE) 
},
>  	{ "sst25wf020",  INFO(0xbf2503, 0, 64 * 1024,  4, SECT_4K | SST_WRITE) 
},
> +	{ "sst25wf020a", INFO(0x621612, 0, 64 * 1024,  4, SECT_4K) },

Is the SST_WRITE not needed on this device ?

Otherwise, looks pretty obvious :)

>  	{ "sst25wf040",  INFO(0xbf2504, 0, 64 * 1024,  8, SECT_4K | SST_WRITE) 
},
>  	{ "sst25wf080",  INFO(0xbf2505, 0, 64 * 1024, 16, SECT_4K | SST_WRITE) 
},

Best regards,
Marek Vasut

  reply	other threads:[~2015-08-14 21:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 17:35 [PATCH] mtd: spi-nor: Add support for sst25wf020a Alexis Ballier
2015-08-14 20:45 ` Marek Vasut [this message]
2015-08-15  8:38   ` Alexis Ballier
2015-08-15 13:29     ` Marek Vasut
2015-09-02 20:56 ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201508142245.14289.marex@denx.de \
    --to=marex@denx.de \
    --cc=aballier@gentoo.org \
    --cc=beanhuo@micron.com \
    --cc=ben@decadent.org.uk \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=juhosg@openwrt.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shijie.huang@intel.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).