Re: [PATCH V6] mtd: m25p80: Modify the name of mtd_info

[Brian Norris <computersforpeace@gmail.com>]

On Mon, Aug 17, 2015 at 06:27:36PM +0200, Jonas Gorski wrote:
> On Mon, Aug 17, 2015 at 6:27 AM, Zhiqiang Hou <B48286@freescale.com> wrote:
> > From: Hou Zhiqiang <B48286@freescale.com>
> >
> > Set the mtd_info's name to a fixed one, so spi flash layouts can
> > be specified by "mtdparts=..." in kernel cmdline, because the
> > cmdlinepart's parser will match the name of mtd_info with the name
> > given in cmdline.
> >
> > So far, if DT is used, the mtd_info's name will be set to the name
> > of spi->dev. It includes spi_master->bus_num, and the bus_num may
> > be dynamically allocated. So, replace the component bus_num with
> > the physical address of spi controller.
> 
> You can easily enforce fixed bus numers in linux using aliases in the
> DT, this is supported
> by the spi core since v3.9 or so.

Interesting. Thanks for the suggestion. I haven't verified it myself,
but if this is a workable solution, then I'd much prefer that to
fiddling with the name here. So, tentative NAK.

> Also won't this change break it for everyone relying on the old naming
> in their commandline mtdparts?

Yes, and that's been my comment on the first several versions. I didn't
have time to bother repeating it on these latter revisions.

Brian