From: Brian Norris <computersforpeace@gmail.com>
To: Michal Suchanek <hramrach@gmail.com>
Cc: Marek Vasut <marex@denx.de>,
Joachim Eastwood <manabian@gmail.com>,
Rafa?? Mi??ecki <zajec5@gmail.com>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Han Xu <han.xu@freescale.com>,
Huang Shijie <shijie.huang@intel.com>
Subject: Re: [RFT PATCH 1/4] mtd: fsl-quadspi: use automatic spi-nor detection
Date: Mon, 17 Aug 2015 19:56:39 -0700 [thread overview]
Message-ID: <20150818025639.GB15907@localhost> (raw)
In-Reply-To: <CAOMqctS-CNu6By1b+s4yEPzgOy3gbtCYuwvET9sRrCnt8Azvhw@mail.gmail.com>
On Fri, Aug 14, 2015 at 07:40:27AM +0200, Michal Suchanek wrote:
> On 14 August 2015 at 01:24, Brian Norris <computersforpeace@gmail.com> wrote:
> > Now, each flash connected to the controller has its own device_node. All
> > this patch is saying is that we don't need to know much about that node;
> > as long as it responds to the READ ID command properly, spi_nor_scan()
> > can autodetect it.
> >
>
> And if there was suppor for a flash chip that does not respond to READ
> ID (or uses a different opcode for it) this patch would break it,
> right?
For the latter: this already doesn't support chips that use different
opcodes.
For the former: we're only talking about the "*-nonjedec" and similar,
right? I'm not confident those were supported well by this driver in the
first place. (And "*-nonjedec" should really die; if it's needed,
support should be added by design, not by accident.)
Perhaps Huang can comment.
Brian
next prev parent reply other threads:[~2015-08-18 2:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 22:46 [RFT PATCH 0/4] mtd: spi-nor: code refactoring and layering Brian Norris
2015-08-13 22:46 ` [RFT PATCH 1/4] mtd: fsl-quadspi: use automatic spi-nor detection Brian Norris
2015-08-13 23:09 ` Marek Vasut
2015-08-13 23:24 ` Brian Norris
2015-08-13 23:54 ` Marek Vasut
2015-08-14 5:40 ` Michal Suchanek
2015-08-18 2:56 ` Brian Norris [this message]
2015-08-18 3:15 ` Han Xu
2015-08-18 8:09 ` Huang Shijie
2015-09-01 18:41 ` Brian Norris
2015-09-01 23:40 ` Han Xu
2015-09-01 23:54 ` Brian Norris
2015-08-13 22:46 ` [RFT PATCH 2/4] mtd: spi-nor: assign mtd->priv in spi_nor_scan() Brian Norris
2015-08-14 14:48 ` Joachim Eastwood
2015-08-13 22:46 ` [RFT PATCH 3/4] mtd: spi-nor: add forward declaration for mtd_info Brian Norris
2015-08-14 14:49 ` Joachim Eastwood
2015-08-13 22:46 ` [RFT PATCH 4/4] mtd: spi-nor: embed struct mtd_info within struct spi_nor Brian Norris
2015-08-14 14:52 ` Joachim Eastwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818025639.GB15907@localhost \
--to=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=han.xu@freescale.com \
--cc=hramrach@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=manabian@gmail.com \
--cc=marex@denx.de \
--cc=shijie.huang@intel.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox