Re: [RFT PATCH 1/4] mtd: fsl-quadspi: use automatic spi-nor detection

Huang Shijie
2015-08-18T08:09:58Z

On Mon, Aug 17, 2015 at 10:15:50PM -0500, Han Xu wrote:
Hi Brian & Han,

> Seems Huang has changed the e-mail address.
>
> On Mon, Aug 17, 2015 at 9:56 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> > On Fri, Aug 14, 2015 at 07:40:27AM +0200, Michal Suchanek wrote:
> >> On 14 August 2015 at 01:24, Brian Norris <computersforpeace@gmail.com> wrote:
> >> > Now, each flash connected to the controller has its own device_node. All
> >> > this patch is saying is that we don't need to know much about that node;
> >> > as long as it responds to the READ ID command properly, spi_nor_scan()
> >> > can autodetect it.
> >> >
> >>
> >> And if there was suppor for a flash chip that does not respond to READ
> >> ID (or uses a different opcode for it) this patch would break it,
> >> right?

Do not worry about the quadspi controller :)

The controller only uses the best NOR flash (or maybe the best NOR flash), I remember
that the NOR flash can support the QUAD DDR read which is not supported not.

So it will not break the driver.

Btw: @Han Xu : I think you can test this patch.

> >
> > For the latter: this already doesn't support chips that use different
> > opcodes.
> >
> > For the former: we're only talking about the "*-nonjedec" and similar,
> > right? I'm not confident those were supported well by this driver in the
> > first place. (And "*-nonjedec" should really die; if it's needed,
> > support should be added by design, not by accident.)
> >
> > Perhaps Huang can comment.

I think this patch is okay. But please wait for Han's test result.

thanks
Huang Shijie