[PATCH] mtd: spi-nor: allow dual/quad reads on S25FL129P

[PATCH] mtd: spi-nor: allow dual/quad reads on S25FL129P

[Jonas Gorski]

According to the datasheet[1], both S25FL129P0 (256kB sectors) and
S25FL129P1 (64kB sectors) support dual read, quad read, dual i/o read
and quad i/o read.

I have verified dual read to be working for S25FL129P1 on a dual
capable spi controller. Quad as well as S25FL129P0 is untested, lacking
hardware to verify.

[1] http://www.spansion.com/Support/Datasheets/S25FL129P_00.pdf

Signed-off-by: Jonas Gorski <jogo@openwrt.org>
---
 drivers/mtd/spi-nor/spi-nor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index c27d427..ed449b4 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -610,8 +610,8 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024,  64, 0) },
 	{ "s25sl12801", INFO(0x012018, 0x0301,  64 * 1024, 256, 0) },
 	{ "s25fl128s",	INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SECT_4K | SPI_NOR_QUAD_READ) },
-	{ "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024,  64, 0) },
-	{ "s25fl129p1", INFO(0x012018, 0x4d01,  64 * 1024, 256, 0) },
+	{ "s25fl129p0", INFO(0x012018, 0x4d00, 256 * 1024,  64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ "s25fl129p1", INFO(0x012018, 0x4d01,  64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "s25sl004a",  INFO(0x010212,      0,  64 * 1024,   8, 0) },
 	{ "s25sl008a",  INFO(0x010213,      0,  64 * 1024,  16, 0) },
 	{ "s25sl016a",  INFO(0x010214,      0,  64 * 1024,  32, 0) },
-- 
2.1.4

Re: [PATCH] mtd: spi-nor: allow dual/quad reads on S25FL129P

[Marek Vasut]

On Wednesday, August 26, 2015 at 02:56:53 PM, Jonas Gorski wrote:
> According to the datasheet[1], both S25FL129P0 (256kB sectors) and
> S25FL129P1 (64kB sectors) support dual read, quad read, dual i/o read
> and quad i/o read.
> 
> I have verified dual read to be working for S25FL129P1 on a dual
> capable spi controller. Quad as well as S25FL129P0 is untested, lacking
> hardware to verify.
> 
> [1] http://www.spansion.com/Support/Datasheets/S25FL129P_00.pdf
> 
> Signed-off-by: Jonas Gorski <jogo@openwrt.org>

I don't have this device, so I cannot test, sorry. On the other hand,
spansion doesn't seem to put b/s in their datasheets, so I'd be happy
to add my:

Reviewed-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

Re: [PATCH] mtd: spi-nor: allow dual/quad reads on S25FL129P

[Brian Norris]

On Wed, Aug 26, 2015 at 03:05:36PM +0200, Marek Vasut wrote:
> On Wednesday, August 26, 2015 at 02:56:53 PM, Jonas Gorski wrote:
> > According to the datasheet[1], both S25FL129P0 (256kB sectors) and
> > S25FL129P1 (64kB sectors) support dual read, quad read, dual i/o read
> > and quad i/o read.
> > 
> > I have verified dual read to be working for S25FL129P1 on a dual
> > capable spi controller. Quad as well as S25FL129P0 is untested, lacking
> > hardware to verify.
> > 
> > [1] http://www.spansion.com/Support/Datasheets/S25FL129P_00.pdf
> > 
> > Signed-off-by: Jonas Gorski <jogo@openwrt.org>
> 
> I don't have this device, so I cannot test, sorry. On the other hand,
> spansion doesn't seem to put b/s in their datasheets, so I'd be happy
> to add my:
> 
> Reviewed-by: Marek Vasut <marex@denx.de>

Applied to l2-mtd.git