From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Bean Huo 霍斌斌 (beanhuo)" <beanhuo@micron.com>
Cc: "dedekind1@gmail.com" <dedekind1@gmail.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"baruch@tkos.co.il" <baruch@tkos.co.il>,
"asierra@xes-inc.com" <asierra@xes-inc.com>,
"guz.fnst@cn.fujitsu.com" <guz.fnst@cn.fujitsu.com>,
"gsi@denx.de" <gsi@denx.de>, "richard@nod.at" <richard@nod.at>,
"David Woodhouse" <dwmw2@infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Frank Liu 刘群 (frankliu)" <frankliu@micron.com>,
"Andrea Scian" <rnd4@dave-tech.it>,
"Peter Pan 潘柏宏 (peterpan)" <peterpan@micron.com>,
"Karl Zhang 张双锣 (karlzhang)" <karlzhang@micron.com>,
"Iwo Mergler" <Iwo.Mergler@netcommwireless.com>,
"Jeff Lauruhn (jlauruhn)" <jlauruhn@micron.com>,
"Stefan Roese" <sr@denx.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/9] fs:ubifs: add hook for UBI bakvol in ubifs layer
Date: Mon, 28 Sep 2015 13:21:59 +0200 [thread overview]
Message-ID: <20150928132159.4738f573@bbrezillon> (raw)
In-Reply-To: <A765B125120D1346A63912DDE6D8B6310BF4CEE8@NTXXIAMBX02.xacn.micron.com>
On Mon, 28 Sep 2015 07:02:52 +0000
Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> wrote:
> Add hook for UBI bakvol in ubifs layer.
>
> open/close bakvol operation in ubifs mount.
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
> fs/ubifs/super.c | 6 ++++++
> fs/ubifs/ubifs.h | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index 9547a278..f3bf548 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -1463,6 +1463,8 @@ static int mount_ubifs(struct ubifs_info *c)
> dbg_gen("max. seq. number: %llu", c->max_sqnum);
> dbg_gen("commit number: %llu", c->cmt_no);
>
> + init_bakvol(c->ubi, 1);
This function is implemented in patch 9 and you're using it here, which
means your series is not bisectable.
Also, do we really want to let UBIFS decide whether this feature should
be enabled or not for the whole UBI device?
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2015-09-28 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 7:02 [PATCH 4/9] fs:ubifs: add hook for UBI bakvol in ubifs layer Bean Huo 霍斌斌 (beanhuo)
2015-09-28 11:21 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928132159.4738f573@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=Iwo.Mergler@netcommwireless.com \
--cc=adrian.hunter@intel.com \
--cc=asierra@xes-inc.com \
--cc=baruch@tkos.co.il \
--cc=beanhuo@micron.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=frankliu@micron.com \
--cc=gsi@denx.de \
--cc=guz.fnst@cn.fujitsu.com \
--cc=jlauruhn@micron.com \
--cc=karlzhang@micron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=peterpan@micron.com \
--cc=richard@nod.at \
--cc=rnd4@dave-tech.it \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox