* [PATCH 1/3] UBI: Fastmap: Simplify expression
@ 2015-07-03 8:36 Richard Weinberger
2015-07-03 8:36 ` [PATCH 2/3] UBI: Fix typo in comment Richard Weinberger
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Richard Weinberger @ 2015-07-03 8:36 UTC (permalink / raw)
To: linux-mtd; +Cc: Richard Weinberger
There is no need to compute pnum again.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/fastmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index 24f2cf6..22db594 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -775,7 +775,7 @@ static int ubi_attach_fastmap(struct ubi_device *ubi,
for (j = 0; j < be32_to_cpu(fm_eba->reserved_pebs); j++) {
int pnum = be32_to_cpu(fm_eba->pnum[j]);
- if ((int)be32_to_cpu(fm_eba->pnum[j]) < 0)
+ if (pnum < 0)
continue;
aeb = NULL;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/3] UBI: Fix typo in comment
2015-07-03 8:36 [PATCH 1/3] UBI: Fastmap: Simplify expression Richard Weinberger
@ 2015-07-03 8:36 ` Richard Weinberger
2015-09-29 1:36 ` Brian Norris
2015-07-03 8:36 ` [PATCH 3/3] UBI: Fix debug message Richard Weinberger
2015-09-29 1:35 ` [PATCH 1/3] UBI: Fastmap: Simplify expression Brian Norris
2 siblings, 1 reply; 9+ messages in thread
From: Richard Weinberger @ 2015-07-03 8:36 UTC (permalink / raw)
To: linux-mtd; +Cc: Richard Weinberger
While we are here fix a s/beween/between typo.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/ubi-media.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/ubi-media.h b/drivers/mtd/ubi/ubi-media.h
index d0d072e..22ed3f6 100644
--- a/drivers/mtd/ubi/ubi-media.h
+++ b/drivers/mtd/ubi/ubi-media.h
@@ -500,7 +500,7 @@ struct ubi_fm_volhdr {
/* struct ubi_fm_volhdr is followed by one struct ubi_fm_eba records */
/**
- * struct ubi_fm_eba - denotes an association beween a PEB and LEB
+ * struct ubi_fm_eba - denotes an association between a PEB and LEB
* @magic: EBA table magic number
* @reserved_pebs: number of table entries
* @pnum: PEB number of LEB (LEB is the index)
--
1.8.4.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] UBI: Fix typo in comment
2015-07-03 8:36 ` [PATCH 2/3] UBI: Fix typo in comment Richard Weinberger
@ 2015-09-29 1:36 ` Brian Norris
2015-10-03 18:10 ` Richard Weinberger
0 siblings, 1 reply; 9+ messages in thread
From: Brian Norris @ 2015-09-29 1:36 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-mtd
On Fri, Jul 03, 2015 at 10:36:15AM +0200, Richard Weinberger wrote:
> While we are here fix a s/beween/between typo.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Brian Norris <computersforpeace@gmail.com>
> ---
> drivers/mtd/ubi/ubi-media.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/ubi-media.h b/drivers/mtd/ubi/ubi-media.h
> index d0d072e..22ed3f6 100644
> --- a/drivers/mtd/ubi/ubi-media.h
> +++ b/drivers/mtd/ubi/ubi-media.h
> @@ -500,7 +500,7 @@ struct ubi_fm_volhdr {
> /* struct ubi_fm_volhdr is followed by one struct ubi_fm_eba records */
>
> /**
> - * struct ubi_fm_eba - denotes an association beween a PEB and LEB
> + * struct ubi_fm_eba - denotes an association between a PEB and LEB
> * @magic: EBA table magic number
> * @reserved_pebs: number of table entries
> * @pnum: PEB number of LEB (LEB is the index)
> --
> 1.8.4.5
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] UBI: Fix debug message
2015-07-03 8:36 [PATCH 1/3] UBI: Fastmap: Simplify expression Richard Weinberger
2015-07-03 8:36 ` [PATCH 2/3] UBI: Fix typo in comment Richard Weinberger
@ 2015-07-03 8:36 ` Richard Weinberger
2015-09-29 1:35 ` Brian Norris
2015-09-29 1:35 ` [PATCH 1/3] UBI: Fastmap: Simplify expression Brian Norris
2 siblings, 1 reply; 9+ messages in thread
From: Richard Weinberger @ 2015-07-03 8:36 UTC (permalink / raw)
To: linux-mtd; +Cc: Richard Weinberger
We have to use j instead of i. i is the volume id
and not the block.
Reported-by: Alexander.Block@continental-corporation.com
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/eba.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c
index b55dc8e..98595c5 100644
--- a/drivers/mtd/ubi/eba.c
+++ b/drivers/mtd/ubi/eba.c
@@ -1409,7 +1409,7 @@ int self_check_eba(struct ubi_device *ubi, struct ubi_attach_info *ai_fastmap,
continue;
ubi_err(ubi, "LEB:%i:%i is PEB:%i instead of %i!",
- vol->vol_id, i, fm_eba[i][j],
+ vol->vol_id, j, fm_eba[i][j],
scan_eba[i][j]);
ubi_assert(0);
}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] UBI: Fix debug message
2015-07-03 8:36 ` [PATCH 3/3] UBI: Fix debug message Richard Weinberger
@ 2015-09-29 1:35 ` Brian Norris
2015-10-03 18:10 ` Richard Weinberger
0 siblings, 1 reply; 9+ messages in thread
From: Brian Norris @ 2015-09-29 1:35 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-mtd
Digging through some old stuff:
On Fri, Jul 03, 2015 at 10:36:16AM +0200, Richard Weinberger wrote:
> We have to use j instead of i. i is the volume id
> and not the block.
>
> Reported-by: Alexander.Block@continental-corporation.com
> Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Brian Norris <computersforpeace@gmail.com>
> ---
> drivers/mtd/ubi/eba.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c
> index b55dc8e..98595c5 100644
> --- a/drivers/mtd/ubi/eba.c
> +++ b/drivers/mtd/ubi/eba.c
> @@ -1409,7 +1409,7 @@ int self_check_eba(struct ubi_device *ubi, struct ubi_attach_info *ai_fastmap,
> continue;
>
> ubi_err(ubi, "LEB:%i:%i is PEB:%i instead of %i!",
> - vol->vol_id, i, fm_eba[i][j],
> + vol->vol_id, j, fm_eba[i][j],
> scan_eba[i][j]);
> ubi_assert(0);
> }
> --
> 1.8.4.5
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] UBI: Fix debug message
2015-09-29 1:35 ` Brian Norris
@ 2015-10-03 18:10 ` Richard Weinberger
0 siblings, 0 replies; 9+ messages in thread
From: Richard Weinberger @ 2015-10-03 18:10 UTC (permalink / raw)
To: Brian Norris; +Cc: Richard Weinberger, linux-mtd@lists.infradead.org
On Tue, Sep 29, 2015 at 3:35 AM, Brian Norris
<computersforpeace@gmail.com> wrote:
> Digging through some old stuff:
>
> On Fri, Jul 03, 2015 at 10:36:16AM +0200, Richard Weinberger wrote:
>> We have to use j instead of i. i is the volume id
>> and not the block.
>>
>> Reported-by: Alexander.Block@continental-corporation.com
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>
> Acked-by: Brian Norris <computersforpeace@gmail.com>
Applied.
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] UBI: Fastmap: Simplify expression
2015-07-03 8:36 [PATCH 1/3] UBI: Fastmap: Simplify expression Richard Weinberger
2015-07-03 8:36 ` [PATCH 2/3] UBI: Fix typo in comment Richard Weinberger
2015-07-03 8:36 ` [PATCH 3/3] UBI: Fix debug message Richard Weinberger
@ 2015-09-29 1:35 ` Brian Norris
2015-10-03 18:09 ` Richard Weinberger
2 siblings, 1 reply; 9+ messages in thread
From: Brian Norris @ 2015-09-29 1:35 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-mtd
On Fri, Jul 03, 2015 at 10:36:14AM +0200, Richard Weinberger wrote:
> There is no need to compute pnum again.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Brian Norris <computersforpeace@gmail.com>
> ---
> drivers/mtd/ubi/fastmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
> index 24f2cf6..22db594 100644
> --- a/drivers/mtd/ubi/fastmap.c
> +++ b/drivers/mtd/ubi/fastmap.c
> @@ -775,7 +775,7 @@ static int ubi_attach_fastmap(struct ubi_device *ubi,
> for (j = 0; j < be32_to_cpu(fm_eba->reserved_pebs); j++) {
> int pnum = be32_to_cpu(fm_eba->pnum[j]);
>
> - if ((int)be32_to_cpu(fm_eba->pnum[j]) < 0)
> + if (pnum < 0)
> continue;
>
> aeb = NULL;
> --
> 1.8.4.5
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-10-03 18:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-03 8:36 [PATCH 1/3] UBI: Fastmap: Simplify expression Richard Weinberger
2015-07-03 8:36 ` [PATCH 2/3] UBI: Fix typo in comment Richard Weinberger
2015-09-29 1:36 ` Brian Norris
2015-10-03 18:10 ` Richard Weinberger
2015-07-03 8:36 ` [PATCH 3/3] UBI: Fix debug message Richard Weinberger
2015-09-29 1:35 ` Brian Norris
2015-10-03 18:10 ` Richard Weinberger
2015-09-29 1:35 ` [PATCH 1/3] UBI: Fastmap: Simplify expression Brian Norris
2015-10-03 18:09 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).