From: Brian Norris <computersforpeace@gmail.com>
To: Graham Moore <grmoore@opensource.altera.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
Alan Tull <atull@opensource.altera.com>,
Dinh Nguyen <dinguyen@opensource.altera.com>,
Yves Vandervennet <yvanderv@opensource.altera.com>,
Enrico Jorns <ejo@pengutronix.de>
Subject: Re: [PATCH] mtd: nand: denali: max_banks calculation changed in revision 5.1
Date: Tue, 29 Sep 2015 12:56:48 -0700 [thread overview]
Message-ID: <20150929195648.GG31505@google.com> (raw)
In-Reply-To: <20150929183121.GC31505@google.com>
On Tue, Sep 29, 2015 at 11:31:21AM -0700, Brian Norris wrote:
> On Tue, Sep 29, 2015 at 10:01:10AM -0500, Graham Moore wrote:
> > On 07/21/2015 09:39 AM, Graham Moore wrote:
> > >diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> > >index 870c7fc..a98b41e 100644
> > >--- a/drivers/mtd/nand/denali.h
> > >+++ b/drivers/mtd/nand/denali.h
> > >@@ -178,6 +178,8 @@
> > >
> > > #define REVISION 0x370
> > > #define REVISION__VALUE 0xffff
> > >+#define MAKE_COMPARABLE_REVISION(x) swab16(x & REVISION__VALUE)
>
> It's probably best to add parentheses around the 'x'.
>
> > >+#define REVISION_5_1 0x00000501
> > >
> > > #define ONFI_DEVICE_FEATURES 0x380
> > > #define ONFI_DEVICE_FEATURES__VALUE 0x003f
> > >
> >
>
> I can fix that up and apply, if no objections.
Pushed to l2-mtd.git with that fixup.
prev parent reply other threads:[~2015-09-29 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 14:39 [PATCH] mtd: nand: denali: max_banks calculation changed in revision 5.1 Graham Moore
2015-09-29 15:01 ` Graham Moore
2015-09-29 18:31 ` Brian Norris
2015-09-29 19:56 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929195648.GG31505@google.com \
--to=computersforpeace@gmail.com \
--cc=atull@opensource.altera.com \
--cc=dinguyen@opensource.altera.com \
--cc=dwmw2@infradead.org \
--cc=ejo@pengutronix.de \
--cc=grmoore@opensource.altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=yvanderv@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).