From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZhJfL-00048O-EB for linux-mtd@lists.infradead.org; Wed, 30 Sep 2015 15:51:36 +0000 Received: by pablk4 with SMTP id lk4so43765234pab.3 for ; Wed, 30 Sep 2015 08:51:14 -0700 (PDT) Date: Wed, 30 Sep 2015 08:51:07 -0700 From: Brian Norris To: Sudip Mukherjee Cc: David Woodhouse , Dongsheng Yang , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, lkp@intel.com Subject: Re: [PATCH v2] mtd: mtdram: fix build error Message-ID: <20150930155107.GA5192@localhost> References: <1443619766-8134-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443619766-8134-1-git-send-email-sudipm.mukherjee@gmail.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Sep 30, 2015 at 06:59:26PM +0530, Sudip Mukherjee wrote: > i386 allmodconfig fails with: > ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined! > ERROR: "__moddi3" [drivers/mtd/devices/mtdram.ko] undefined! > > arm allmodconfig fails with: > ERROR: "__aeabi_uldivmod" [drivers/mtd/devices/mtdram.ko] undefined! > ERROR: "__aeabi_ldivmod" [drivers/mtd/devices/mtdram.ko] undefined! > > mips allmodconfig fails with: > ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined! > ERROR: "__moddi3" [drivers/mtd/devices/mtdram.ko] undefined! > > The modulus operation is not being supported by these compilers. Use > do_div() instead which returns the remainder. > > Fixes: 7827e3acad2d ("mtd: mtdram: check offs and len in mtdram->erase") > Signed-off-by: Sudip Mukherjee > --- > > v1 showed build warning with cris and xtensa. I have checked v2 with > arm, cris and xtensa. I already reverted the bad patch, so this doesn't apply any more... If you want to send a squashed patch that redoes this properly, I can take it. Brian