* Re: [PATCH v2 19/25] pxa2xx-flash: switch from ioremap_cache to memremap
[not found] ` <20150725023945.8664.34842.stgit@dwillia2-desk3.amr.corp.intel.com>
@ 2015-10-02 17:51 ` Brian Norris
2015-10-09 21:33 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2015-10-02 17:51 UTC (permalink / raw)
To: Dan Williams
Cc: tglx, mingo, hpa, linux-arch, toshi.kani, linux-nvdimm,
linux-kernel, rmk+kernel, David Woodhouse, hch, linux-arm-kernel,
linux-mtd
+ linux-mtd
On Fri, Jul 24, 2015 at 10:39:45PM -0400, Dan Williams wrote:
> In preparation for deprecating ioremap_cache() convert its usage in
> pxa2xx-flash to memremap.
>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/mtd/maps/pxa2xx-flash.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
> index 12fa75df5008..758a8a7f86d9 100644
> --- a/drivers/mtd/maps/pxa2xx-flash.c
> +++ b/drivers/mtd/maps/pxa2xx-flash.c
> @@ -71,8 +71,8 @@ static int pxa2xx_flash_probe(struct platform_device *pdev)
> info->map.name);
> return -ENOMEM;
> }
> - info->map.cached =
> - ioremap_cache(info->map.phys, info->map.size);
> + info->map.cached = memremap(info->map.phys, info->map.size,
> + MEMREMAP_CACHE);
Should the corresponding iounmap() be changed too? Looks like a pretty
thin wrapper right now, but it seems like the API would suggest we do
this anyway.
> if (!info->map.cached)
> printk(KERN_WARNING "Failed to ioremap cached %s\n",
> info->map.name);
>
Brian
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 19/25] pxa2xx-flash: switch from ioremap_cache to memremap
2015-10-02 17:51 ` [PATCH v2 19/25] pxa2xx-flash: switch from ioremap_cache to memremap Brian Norris
@ 2015-10-09 21:33 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2015-10-09 21:33 UTC (permalink / raw)
To: Brian Norris
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-arch,
Kani, Toshimitsu, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, Russell King, David Woodhouse,
Christoph Hellwig, linux-arm-kernel@lists.infradead.org,
linux-mtd
On Fri, Oct 2, 2015 at 10:51 AM, Brian Norris
<computersforpeace@gmail.com> wrote:
> + linux-mtd
>
> On Fri, Jul 24, 2015 at 10:39:45PM -0400, Dan Williams wrote:
>> In preparation for deprecating ioremap_cache() convert its usage in
>> pxa2xx-flash to memremap.
>>
>> Cc: David Woodhouse <dwmw2@infradead.org>
>> Cc: Brian Norris <computersforpeace@gmail.com>
>> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
>> ---
>> drivers/mtd/maps/pxa2xx-flash.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
>> index 12fa75df5008..758a8a7f86d9 100644
>> --- a/drivers/mtd/maps/pxa2xx-flash.c
>> +++ b/drivers/mtd/maps/pxa2xx-flash.c
>> @@ -71,8 +71,8 @@ static int pxa2xx_flash_probe(struct platform_device *pdev)
>> info->map.name);
>> return -ENOMEM;
>> }
>> - info->map.cached =
>> - ioremap_cache(info->map.phys, info->map.size);
>> + info->map.cached = memremap(info->map.phys, info->map.size,
>> + MEMREMAP_CACHE);
>
> Should the corresponding iounmap() be changed too? Looks like a pretty
> thin wrapper right now, but it seems like the API would suggest we do
> this anyway.
>
Yes, thanks for that catch, addressed in the next rev.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-09 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150725023649.8664.59145.stgit@dwillia2-desk3.amr.corp.intel.com>
[not found] ` <20150725023945.8664.34842.stgit@dwillia2-desk3.amr.corp.intel.com>
2015-10-02 17:51 ` [PATCH v2 19/25] pxa2xx-flash: switch from ioremap_cache to memremap Brian Norris
2015-10-09 21:33 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).