From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZloYG-0005OB-Dd for linux-mtd@lists.infradead.org; Tue, 13 Oct 2015 01:38:53 +0000 Received: by padhy16 with SMTP id hy16so4177280pad.1 for ; Mon, 12 Oct 2015 18:38:31 -0700 (PDT) Date: Mon, 12 Oct 2015 18:38:28 -0700 From: Brian Norris To: Aurelien Chanot Cc: linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: spi-nor: Add support for Micron n25q032a Message-ID: <20151013013828.GU107187@google.com> References: <20151007191008.GA31411@achanot-lt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151007191008.GA31411@achanot-lt> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 07, 2015 at 12:10:08PM -0700, Aurelien Chanot wrote: > The N25Q032A is identical to the N25Q032 except it has a different > supply voltage range. Therefore, it has a new JEDEC ID. > > Signed-off-by: Aurelien Chanot Applied to l2-mtd.git > --- > drivers/mtd/spi-nor/spi-nor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index f59aedf..9122a2e 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -585,6 +585,7 @@ static const struct flash_info spi_nor_ids[] = { > > /* Micron */ > { "n25q032", INFO(0x20ba16, 0, 64 * 1024, 64, SPI_NOR_QUAD_READ) }, > + { "n25q032a", INFO(0x20bb16, 0, 64 * 1024, 64, SPI_NOR_QUAD_READ) }, I know the original entry doesn't specify this, but does this flash support 4K sectors and dual read? We should add the flags. Brian > { "n25q064", INFO(0x20ba17, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_QUAD_READ) }, > { "n25q064a", INFO(0x20bb17, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_QUAD_READ) }, > { "n25q128a11", INFO(0x20bb18, 0, 64 * 1024, 256, SPI_NOR_QUAD_READ) },