linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Frans Klaver <fransklaver@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 00/60] Fix mtd parent device not showing up in sysfs
Date: Tue, 13 Oct 2015 10:14:18 -0700	[thread overview]
Message-ID: <20151013171418.GV107187@google.com> (raw)
In-Reply-To: <1433968754-10651-1-git-send-email-fransklaver@gmail.com>

Hi Frans,

On Wed, Jun 10, 2015 at 10:38:14PM +0200, Frans Klaver wrote:
> Here's the second iteration of a series stemming from a previous discussion
> about mtd devices not showing up in sysfs properly[1]. While the original
> series 27 patches, this one should cover all drivers that suffer from this
> issue, and shamelessly hits 60. Again, if it's preferred that the patches are
> grouped differently, like by mtd subdir, I'd be happy to resend. Until then,
> we'll make do with this.
> 
> This series teaches add_mtd_device() to set name and owner based on the set
> parent device, if dev.parent is filled in, and name resp. owner isn't already
> filled in. All drivers that I could find that don't set the parent are touched
> to set the parent device, and remove the name and owner assignment in cases
> where I'm sure the resulting name will not change. Only the latter is done in
> cases where I would find the driver explicitly filling in the owner.
> 
> Thanks for having a go at your favorite MTD,
> Frans
> 
> v1..v2
>   - Overall: make it more clear that it's about a parent device symlink gone
>     missing (thanks, Brian)
>   - Fix compile error in 30: "fsmc_nand: show parent device in sysfs"
>   - Fix possible null-pointer dereference in 02: "mtd: core: set some
>     defaults..."
> 
> [1] https://lkml.org/lkml/2014/5/26/586

Thanks for the patches. I've tested a few drivers and compile tested as
much as I can, and everything looks good. Patches 5 and 59 (m25p80.c and
fsl-quadspi.c) didn't apply cleanly yet, as those drivers have had some
concurrent changes, so I didn't take them yet. If it's trivial to fix
up, I'll apply themself. Stay tuned.

Regards,
Brian

      parent reply	other threads:[~2015-10-13 17:14 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 20:38 [PATCH v2 00/60] Fix mtd parent device not showing up in sysfs Frans Klaver
2015-06-10 20:38 ` [PATCH v2 01/60] mtd: core: tone down suggestion that dev.parent should be set Frans Klaver
2015-06-10 20:38 ` [PATCH v2 02/60] mtd: core: set some defaults when dev.parent is set Frans Klaver
2015-06-10 20:38 ` [PATCH v2 03/60] mtd: devices: bcm47xxflash: show parent device in sysfs Frans Klaver
2015-06-10 20:38 ` [PATCH v2 04/60] mtd: devices: docg3: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 05/60] mtd: devices: m25p80: " Frans Klaver
2015-10-13 17:37   ` Brian Norris
2015-10-13 17:41     ` Frans Klaver
2015-06-10 20:38 ` [PATCH v2 06/60] mtd: devices: mtd_dataflash: drop owner assignment Frans Klaver
2015-06-10 20:38 ` [PATCH v2 07/60] mtd: devices: spear_smi: show parent device in sysfs Frans Klaver
2015-06-10 20:38 ` [PATCH v2 08/60] mtd: devices: sst251: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 09/60] mtd: lpddr: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 10/60] mtd: maps: bfin-async-flash: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 11/60] mtd: maps: gpio-addr-flash: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 12/60] mtd: maps: intel_vr_nor: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 13/60] mtd: maps: ixp4xx: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 14/60] mtd: maps: lantiq-flash: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 15/60] mtd: maps: latch-addr-flash: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 16/60] mtd: maps: physmap: drop owner assignment Frans Klaver
2015-06-10 20:38 ` [PATCH v2 17/60] mtd: maps: physmap_of: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 18/60] mtd: maps: plat_ram: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 19/60] mtd: maps: pxa2xx-flash: show parent device in sysfs Frans Klaver
2015-06-10 20:38 ` [PATCH v2 20/60] mtd: maps: rbtx4939-flash: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 21/60] mtd: maps: sa1100-flash: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 22/60] mtd: nand: atmel_nand: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 23/60] mtd: nand: au1550nd: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 24/60] mtd: nand: bcm47xxnflash: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 25/60] mtd: nand: bf5xx_nand: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 26/60] mtd: nand: cafe_nand: drop owner assignment Frans Klaver
2015-06-10 20:38 ` [PATCH v2 27/60] mtd: nand: davinci_nand: drop owner and name assignment Frans Klaver
2015-06-10 20:38 ` [PATCH v2 28/60] mtd: nand: denali: drop owner assignment Frans Klaver
2015-06-10 20:38 ` [PATCH v2 29/60] mtd: nand: docg4: show parent device in sysfs Frans Klaver
2015-06-10 20:38 ` [PATCH v2 30/60] mtd: nand: fsl_elbc_nand: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 31/60] mtd: nand: fsl_ifc_nand: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 32/60] mtd: nand: fsl_upm: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 33/60] mtd: nand: fsmc_nand: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 34/60] mtd: nand: gpio: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 35/60] mtd: nand: gpmi-nand: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 36/60] mtd: nand: hisi504_nand: drop owner assignment Frans Klaver
2015-06-10 20:38 ` [PATCH v2 37/60] mtd: nand: jz4740_nand: show parent device in sysfs Frans Klaver
2015-06-10 20:38 ` [PATCH v2 38/60] mtd: nand: lpc32xx_mlc: drop owner assignment Frans Klaver
2015-06-10 20:38 ` [PATCH v2 39/60] mtd: nand: mpc5121_nfc: show parent device in sysfs Frans Klaver
2015-06-10 20:38 ` [PATCH v2 40/60] mtd: nand: mxc_nand: drop owner assignment Frans Klaver
2015-06-10 20:38 ` [PATCH v2 41/60] mtd: nand: ndfc: show parent device in sysfs Frans Klaver
2015-06-10 20:38 ` [PATCH v2 42/60] mtd: nand: nuc900_nand: " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 43/60] mtd: nand: omap2: show parent device structure " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 44/60] mtd: nand: orion_nand: show parent device " Frans Klaver
2015-06-10 20:38 ` [PATCH v2 45/60] mtd: nand: pasemi_nand: " Frans Klaver
2015-06-10 20:39 ` [PATCH v2 46/60] mtd: nand: plat_nand: " Frans Klaver
2015-06-10 20:39 ` [PATCH v2 47/60] mtd: nand: pxa3xx_nand: " Frans Klaver
2015-06-10 20:39 ` [PATCH v2 48/60] mtd: nand: r852: drop owner assignment Frans Klaver
2015-06-10 20:39 ` [PATCH v2 49/60] mtd: nand: s3c2410: show parent device in sysfs Frans Klaver
2015-06-10 20:39 ` [PATCH v2 50/60] mtd: nand: sh_flctl: " Frans Klaver
2015-06-10 20:39 ` [PATCH v2 51/60] mtd: nand: sharpsl: " Frans Klaver
2015-06-10 20:39 ` [PATCH v2 52/60] mtd: nand: socrates_nand: drop owner assignment Frans Klaver
2015-06-10 20:39 ` [PATCH v2 53/60] mtd: nand: sunxi_nand: " Frans Klaver
2015-06-10 20:39 ` [PATCH v2 54/60] mtd: nand: tmio_nand: show parent device in sysfs Frans Klaver
2015-06-10 20:39 ` [PATCH v2 55/60] mtd: nand: txx9ndfmc: " Frans Klaver
2015-06-10 20:39 ` [PATCH v2 56/60] mtd: onenand: generic: " Frans Klaver
2015-06-10 20:39 ` [PATCH v2 57/60] mtd: onenand: omap2: drop owner and name assignment Frans Klaver
2015-06-10 20:39 ` [PATCH v2 58/60] mtd: onenand: samsung: drop owner assignment Frans Klaver
2015-06-10 20:39 ` [PATCH v2 59/60] mtd: spi-nor: fsl-quadspi: show parent device in sysfs Frans Klaver
2015-06-10 20:39 ` [PATCH v2 60/60] staging: mt29f_spinand: " Frans Klaver
2015-06-10 20:43 ` [PATCH v2 00/60] Fix mtd parent device not showing up " Frans Klaver
2015-10-13 17:14 ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013171418.GV107187@google.com \
    --to=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=fransklaver@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).