From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zm3W8-00010A-HV for linux-mtd@lists.infradead.org; Tue, 13 Oct 2015 17:37:41 +0000 Received: by pabve7 with SMTP id ve7so27693413pab.2 for ; Tue, 13 Oct 2015 10:37:19 -0700 (PDT) Date: Tue, 13 Oct 2015 10:37:17 -0700 From: Brian Norris To: Frans Klaver Cc: David Woodhouse , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 05/60] mtd: devices: m25p80: show parent device in sysfs Message-ID: <20151013173354.GW107187@google.com> References: <1433968754-10651-1-git-send-email-fransklaver@gmail.com> <1433968754-10651-6-git-send-email-fransklaver@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433968754-10651-6-git-send-email-fransklaver@gmail.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 10, 2015 at 10:38:19PM +0200, Frans Klaver wrote: > Fix a bug where mtd parent device symlinks aren't shown in sysfs. > > Signed-off-by: Frans Klaver This is one of the patches that didn't apply... > --- > drivers/mtd/devices/m25p80.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > index 3af137f..dfa6ee0 100644 > --- a/drivers/mtd/devices/m25p80.c > +++ b/drivers/mtd/devices/m25p80.c > @@ -206,6 +206,7 @@ static int m25p_probe(struct spi_device *spi) > > spi_set_drvdata(spi, flash); > flash->mtd.priv = nor; > + flash->mtd.dev.parent = &spi->dev; ...but I don't think this patch is actually necessary. See spi_nor_scan(), which assigns mtd->dev.parent for us. So as long as the driver assigns the spi_nor::dev field, the spi-nor framework handles this for us. Same comment applies to fsl-quadspi.c (patch 59), which also didn't apply cleanly. So I don't think we need either of these patches. > flash->spi = spi; > > if (spi->mode & SPI_RX_QUAD) Regards, Brian