From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-bl2on0143.outbound.protection.outlook.com ([65.55.169.143]
 helo=na01-bl2-obe.outbound.protection.outlook.com)
 by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux))
 id 1Zm70N-0000HC-Ts
 for linux-mtd@lists.infradead.org; Tue, 13 Oct 2015 21:21:08 +0000
Date: Tue, 13 Oct 2015 16:10:07 -0500
From: Han Xu <han.xu@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
CC: <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 1/2] mtd: fsl-quadspi: fix printk() format warning for
 size_t
Message-ID: <20151013211005.GA654@chopperman.am.freescale.net>
References: <1444682116-4708-1-git-send-email-computersforpeace@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1444682116-4708-1-git-send-email-computersforpeace@gmail.com>
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Mon, Oct 12, 2015 at 01:35:15PM -0700, Brian Norris wrote:
> Seen when compile-testing on non-32-bit arch:
> 
>     CC      drivers/mtd/spi-nor/fsl-quadspi.o
>   drivers/mtd/spi-nor/fsl-quadspi.c: In function 'fsl_qspi_read':
>   drivers/mtd/spi-nor/fsl-quadspi.c:873:2: warning: format '%d' expects argument of type 'int', but argument 6 has type 'size_t' [-Wformat=]
>     dev_dbg(q->dev, "cmd [%x],read from 0x%p, len:%d\n",
>     ^
> 
> Also drop the '0x' prefixing to the '%p' formatter, since %p already
> knows how to format pointers appropriately.
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Han Xu <han.xu@freescale.com>
> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 2954f89fc8be..ca259faf4591 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -868,7 +868,7 @@ static int fsl_qspi_read(struct spi_nor *nor, loff_t from,
>  		}
>  	}
>  
> -	dev_dbg(q->dev, "cmd [%x],read from 0x%p, len:%d\n",
> +	dev_dbg(q->dev, "cmd [%x],read from %p, len:%zd\n",
>  		cmd, q->ahb_addr + q->chip_base_addr + from - q->memmap_offs,
>  		len);
>  
Acked-by: Han xu <han.xu@freescale.com>
> -- 
> 2.6.0.rc2.230.g3dd15c0
> 

-- 
Best Regards,

Han "Allen" Xu