From: Aurelien Chanot <chanot.a@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: spi-nor: Add support for Micron n25q032a
Date: Tue, 13 Oct 2015 14:41:53 -0700 [thread overview]
Message-ID: <20151013214153.GA1079@achanot-lt> (raw)
In-Reply-To: <20151013013828.GU107187@google.com>
On Mon, Oct 12, 2015 at 06:38:28PM -0700, Brian Norris wrote:
> On Wed, Oct 07, 2015 at 12:10:08PM -0700, Aurelien Chanot wrote:
> > The N25Q032A is identical to the N25Q032 except it has a different
> > supply voltage range. Therefore, it has a new JEDEC ID.
> >
> > Signed-off-by: Aurelien Chanot <chanot.a@gmail.com>
>
> Applied to l2-mtd.git
>
> > ---
> > drivers/mtd/spi-nor/spi-nor.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index f59aedf..9122a2e 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -585,6 +585,7 @@ static const struct flash_info spi_nor_ids[] = {
> >
> > /* Micron */
> > { "n25q032", INFO(0x20ba16, 0, 64 * 1024, 64, SPI_NOR_QUAD_READ) },
> > + { "n25q032a", INFO(0x20bb16, 0, 64 * 1024, 64, SPI_NOR_QUAD_READ) },
>
> I know the original entry doesn't specify this, but does this flash
> support 4K sectors and dual read? We should add the flags.
Yes it does support 4k erase subsectors and, quad and dual fast read.
We can create a new patch to update the flags.
>
> Brian
>
> > { "n25q064", INFO(0x20ba17, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_QUAD_READ) },
> > { "n25q064a", INFO(0x20bb17, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_QUAD_READ) },
> > { "n25q128a11", INFO(0x20bb18, 0, 64 * 1024, 256, SPI_NOR_QUAD_READ) },
>
prev parent reply other threads:[~2015-10-13 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 19:10 [PATCH] mtd: spi-nor: Add support for Micron n25q032a Aurelien Chanot
2015-10-13 1:38 ` Brian Norris
2015-10-13 21:41 ` Aurelien Chanot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013214153.GA1079@achanot-lt \
--to=chanot.a@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).