From: Brian Norris <computersforpeace@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: han.xu@freescale.com, linux-mtd@lists.infradead.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] mtd: fsl-quadspi: Include <linux/sizes.h> to avoid build error
Date: Wed, 14 Oct 2015 09:26:36 -0700 [thread overview]
Message-ID: <20151014162636.GH107187@google.com> (raw)
In-Reply-To: <1444793984-21655-1-git-send-email-festevam@gmail.com>
On Wed, Oct 14, 2015 at 12:39:44AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Building for x86 results in the following build errors:
>
> drivers/mtd/spi-nor/fsl-quadspi.c: In function 'fsl_qspi_init_lut':
> >> drivers/mtd/spi-nor/fsl-quadspi.c:355:21: error: 'SZ_16M' undeclared (first use in this function)
> if (q->nor_size <= SZ_16M) {
> ^
> drivers/mtd/spi-nor/fsl-quadspi.c:355:21: note: each undeclared identifier is reported only once for each function it appears in
> drivers/mtd/spi-nor/fsl-quadspi.c: In function 'fsl_qspi_read':
> >> drivers/mtd/spi-nor/fsl-quadspi.c:208:27: error: 'SZ_4M' undeclared (first use in this function)
> #define QUADSPI_MIN_IOMAP SZ_4M
> ^
> >> drivers/mtd/spi-nor/fsl-quadspi.c:845:25: note: in expansion of macro 'QUADSPI_MIN_IOMAP'
> q->memmap_len = len > QUADSPI_MIN_IOMAP ? len : QUADSPI_MIN_IOMAP;
>
> Explicitly include <linux/sizes.h> to fix the problem.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied to l2-mtd.git. Thanks.
prev parent reply other threads:[~2015-10-14 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 3:39 [PATCH] mtd: fsl-quadspi: Include <linux/sizes.h> to avoid build error Fabio Estevam
2015-10-14 16:26 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014162636.GH107187@google.com \
--to=computersforpeace@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=han.xu@freescale.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).