From: Brian Norris <computersforpeace@gmail.com>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: outreachy-kernel@googlegroups.com, y2038@lists.linaro.org,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org
Subject: Re: [RESEND v2] mtd: tests: Replace timeval with ktime_t
Date: Mon, 26 Oct 2015 13:24:29 -0700 [thread overview]
Message-ID: <20151026202429.GH13239@google.com> (raw)
In-Reply-To: <1445525994-15331-1-git-send-email-shraddha.6596@gmail.com>
On Thu, Oct 22, 2015 at 08:29:54PM +0530, Shraddha Barke wrote:
> Changes the 32-bit time type timeval to the 64-bit time type
> ktime_t, since 32-bit systems using struct timeval will break in the
> year 2038. Correspondingly change do_gettimeofday() to ktime_get()
> since ktime_get returns a ktime_t, but do_gettimeofday returns a
> struct timeval.Here, ktime_get() is used instead of ktime_get_real()
> since ktime_get() uses monotonic clock.
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Looks OK. With luck, these tests will be moving out of the kernel and
into user space soon anyway, but that's no reason not to fix this one.
Applied to l2-mtd.git
prev parent reply other threads:[~2015-10-26 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 14:59 [RESEND v2] mtd: tests: Replace timeval with ktime_t Shraddha Barke
2015-10-26 20:24 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026202429.GH13239@google.com \
--to=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=shraddha.6596@gmail.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).