From: Vinod Koul <vinod.koul@intel.com>
To: Han Xu <b45815@freescale.com>
Cc: shijie.huang@arm.com, dwmw2@infradead.org,
computersforpeace@gmail.com, boris.brezillon@free-electrons.com,
fabio.estevam@freescale.com, hofrat@osadl.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
dan.j.williams@intel.com, dmaengine@vger.kernel.org
Subject: Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode
Date: Sat, 31 Oct 2015 07:12:44 +0530 [thread overview]
Message-ID: <20151031014244.GF21326@localhost> (raw)
In-Reply-To: <1445983540-27155-3-git-send-email-b45815@freescale.com>
On Tue, Oct 27, 2015 at 05:05:35PM -0500, Han Xu wrote:
>
> -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma)
> +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma)
This change seems unrelated to patch description, can you explain why?
> +#ifdef CONFIG_PM_SLEEP
> +static int mxs_dma_pm_resume(struct device *dev)
> +{
> + struct mxs_dma_engine *mxs_dma = dev_get_drvdata(dev);
> + int ret;
> +
> + ret = mxs_dma_init(mxs_dma);
> + if (ret)
> + return ret;
> + return 0;
why not return mxs_dma_init() then!
--
~Vinod
next prev parent reply other threads:[~2015-10-31 1:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 22:05 [PATCH v7 0/7] mtd: nand: gpmi: gpmi-nand DSM and bitflip support Han Xu
2015-10-27 22:05 ` [PATCH v7 1/7] mtd: nand: gpmi: add gpmi dsm supend/resume support Han Xu
2015-10-27 22:05 ` [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode Han Xu
2015-10-27 23:25 ` Fabio Estevam
2015-10-31 1:42 ` Vinod Koul [this message]
2015-11-02 15:29 ` Thomas Petazzoni
2015-11-02 15:46 ` [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode' Vinod Koul
2015-10-27 22:05 ` [PATCH v7 3/7] dmaengine: mxs: add i.MX7D APBH DMA support Han Xu
2015-10-29 21:08 ` Andy Shevchenko
2015-10-29 21:03 ` Han Xu
2015-10-29 21:17 ` Andy Shevchenko
2015-10-29 21:09 ` Han Xu
2015-10-27 22:05 ` [PATCH v7 4/7] mtd: nand: gpmi: may use minimum required ecc for 744 oobsize NAND Han Xu
2015-10-27 22:05 ` [PATCH v7 5/7] mtd: nand: gpmi: add GPMI NAND support for i.MX7D Han Xu
2015-10-27 22:05 ` [PATCH v7 6/7] mtd: nand: gpmi: correct bitflip for erased NAND page Han Xu
2015-10-27 22:05 ` [PATCH v7 7/7] mtd: nand: gpmi: support NAND on i.MX6UL Han Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151031014244.GF21326@localhost \
--to=vinod.koul@intel.com \
--cc=b45815@freescale.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@freescale.com \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie.huang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).