linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Cc: david@sigma-star.at, dedekind1@gmail.com, richard@nod.at,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH V3 01/27] mtd-utils: Restructure the mtd-utils source.
Date: Wed, 11 Nov 2015 14:30:07 -0800	[thread overview]
Message-ID: <20151111223007.GC71848@google.com> (raw)
In-Reply-To: <1446261121-9978-1-git-send-email-yangds.fnst@cn.fujitsu.com>

On Sat, Oct 31, 2015 at 11:12:01AM +0800, Dongsheng Yang wrote:
> * There is no code modification in this commit, only moving
> * the files to proper place.
> 
> The user tools looks a little messy as we place almost
> the all tools in the root directory of mtd-utils. To make
> it more clear, I propose to introduce the following structure
> for our source code.
> 
> mtd-utils/
> 	|-- lib
> 	|-- include
> 	|-- misc-utils
> 	|-- jffsX-utils
> 	|-- nand-utils
> 	|-- nor-utils
> 	|-- ubi-utils
> 	|-- ubifs-utils
> 	`-- tests
> 
> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
> changelog:
> 	v1:
> 		- move tools in flash-utils to misc-utils
> 		- change dir in gitignore
> 		- remove flash_info in gitignore
> 		- add mtdpart in gitignore
>  .gitignore                                         | 54 +++++++++----------

This patch doesn't apply, due to .gitignore. I don't know what repo
you're patching of, but it's not the tip of mtd-utils.git...

...

> diff --git a/.gitignore b/.gitignore
> index 83ca938..e1d23cd 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -18,33 +18,33 @@
>  #
>  # Our programs
>  #
> -/doc_loadbios
> -/docfdisk
> -/flash_erase
> -/flash_info
> -/flash_lock
> -/flash_otp_dump
> -/flash_otp_info
> -/flash_otp_lock
> -/flash_otp_write
> -/flash_unlock
> -/flashcp
> -/ftl_check
> -/ftl_format
> -/jffs2dump
> -/jffs2reader
> -/mkfs.jffs2
> -/mtd_debug

You're missing mtdpart?

> -/nanddump
> -/nandtest
> -/nandwrite
> -/nftl_format
> -/nftldump
> -/recv_image
> -/rfddump
> -/rfdformat
> -/serve_image
> -/sumtool
> +/misc-utils/mtdpart

But it shows up here?

> +/misc-utils/doc_loadbios
> +/misc-utils/docfdisk
> +/misc-utils/flash_erase
> +/misc-utils/flash_lock
> +/misc-utils/flash_otp_dump
> +/misc-utils/flash_otp_info
> +/misc-utils/flash_otp_lock
> +/misc-utils/flash_otp_write
> +/misc-utils/flash_unlock
> +/misc-utils/flashcp
> +/misc-utils/ftl_check
> +/misc-utils/ftl_format
> +/jffsX-utils/jffs2dump
> +/jffsX-utils/jffs2reader
> +/jffsX-utils/mkfs.jffs2
> +/misc-utils/mtd_debug
> +/nand-utils/nanddump
> +/nand-utils/nandtest
> +/nand-utils/nandwrite
> +/nand-utils/nftl_format
> +/nand-utils/nftldump
> +/misc-utils/recv_image
> +/nor-utils/rfddump
> +/nor-utils/rfdformat
> +/misc-utils/serve_image
> +/jffsX-utils/sumtool
>  
>  #
>  # Top-level generic files

Brian

  reply	other threads:[~2015-11-11 22:30 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15  4:04 [PATCH v2 00/27] Introduce ubifs_dump in ubifs-utils Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 01/27] mtd-utils: Restructure the mtd-utils source Dongsheng Yang
2015-10-15  4:06   ` Dongsheng Yang
2015-10-15  4:10   ` [RESEND PATCH " Dongsheng Yang
2015-10-27 23:00     ` Brian Norris
2015-10-31  2:38       ` Dongsheng Yang
2015-10-31  3:12     ` [PATCH V3 " Dongsheng Yang
2015-11-11 22:30       ` Brian Norris [this message]
2015-11-11 22:40         ` Brian Norris
2015-11-12  7:20           ` Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 02/27] ubifs: pick some common definitions into ubifs_common.h Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 03/27] ubifs: move the all io related code into io.[h|c] Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 04/27] ubifs: remove the including of mkfs.ubifs.h in lpt.c Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 05/27] ubifs: cut off the dependence from compr.o to mkfs.ubifs Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 06/27] ubifs: cut off the dependence from devtable to mkfs.ubifs.h Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 07/27] ubifs: introduce ubifs-utils/include and ubifs-utils/lib Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 08/27] ubifs: move more functions into io lib Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 09/27] ubifs: introduce a new tool ubifs_dump Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 10/27] ubifs: introduce list.h Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 11/27] ubifs: copy some important data in ubifs.h from kernel to ubifs-utils Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 12/27] ubifs: copy some important functions in key.h " Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 13/27] ubifs: ubifs_dump: add dump_ch and dump_node functions Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 14/27] ubifs: defs.h: introduce some compatible definition for printk class Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 15/27] ubifs: io: introduce ubifs_read function to read ubi volume Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 16/27] ubifs: ubifs_dump: dump super block Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 17/27] ubifs: introduce scan for ubifs-utils Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 18/27] ubifs: add some more compatible definitions in defs.h Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 19/27] ubifs: ubifs_dump: dump master node Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 20/27] ubifs: ubifs_dump: dump log area Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 21/27] ubifs: introduce lprops lib Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 22/27] ubifs: lpt: implement functions to scan lpt Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 23/27] ubifs: ubifs_dump: dump lpt area Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 24/27] ubifs: ubifs_dump: dump index area Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 25/27] ubifs: defs.h: introduce some compatible definitions about integer such as __u16 Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 26/27] ubifs: introduce hexdump lib Dongsheng Yang
2015-10-15  4:04 ` [PATCH v2 27/27] ubifs: ubifs_dump: dump data in hex format Dongsheng Yang
2015-10-31  3:13 ` [PATCH] gitignore: add ubifs_dump to gitignore Dongsheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151111223007.GC71848@google.com \
    --to=computersforpeace@gmail.com \
    --cc=david@sigma-star.at \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=yangds.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).