From: Brian Norris <computersforpeace@gmail.com>
To: Marcus Prebble <marcus.prebble@axis.com>
Cc: "Marcus Prebble" <prebble@axis.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Ricard Wanderlöf" <ricardw@axis.com>,
"Richard Weinberger" <richard@nod.at>
Subject: Re: [PATCH] mtd-utils: lib: mtd_read: Take the buffer offset into account when reading
Date: Fri, 13 Nov 2015 11:17:48 -0800 [thread overview]
Message-ID: <20151113191748.GH8456@google.com> (raw)
In-Reply-To: <A612847CFE53224C91B23E3A5B48BAC7C6EFB4B65B@xmail3.se.axis.com>
Hi,
On Fri, Nov 13, 2015 at 11:07:12AM +0100, Marcus Prebble wrote:
> Thanks for looking at the patch!
Thanks for the patch!
> On Thu, 2015-11-12 at 11:09 -0800, Brian Norris wrote:
> > Patch looks OK. Did you test it? Have you seen MTD drivers that will
> > return short reads?
>
> I only noticed in passing, not because I was hit by the error. I smoke
> tested it, but did not hack a driver to return less than len.
> If I had to guess, I would say that in nearly all cases the drivers do
> not return short reads otherwise this would probably have been picked up
> by now.
OK, that's fine. It's good to know when things are likely to cause real
problems vs. when things need fixed just for best practice.
BTW, I noticed there isn't a 'Signed-off-by' tag in the patch. It's
mostly a formality, but we really shouldn't be taking patches without
it. Can you paste one in reply to your patch, and I'll C&P it?
Regards,
Brian
next prev parent reply other threads:[~2015-11-13 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 12:13 [PATCH] mtd-utils: lib: mtd_read: Take the buffer offset into account when reading Marcus Prebble
2015-11-12 19:09 ` Brian Norris
2015-11-13 10:07 ` Marcus Prebble
2015-11-13 19:17 ` Brian Norris [this message]
2015-11-17 8:43 ` Marcus Prebble
2015-11-17 20:34 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151113191748.GH8456@google.com \
--to=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marcus.prebble@axis.com \
--cc=prebble@axis.com \
--cc=ricardw@axis.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).