From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x236.google.com ([2607:f8b0:400e:c03::236]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZxJrQ-0002Ls-2r for linux-mtd@lists.infradead.org; Fri, 13 Nov 2015 19:18:17 +0000 Received: by pacej9 with SMTP id ej9so1713380pac.2 for ; Fri, 13 Nov 2015 11:17:51 -0800 (PST) Date: Fri, 13 Nov 2015 11:17:48 -0800 From: Brian Norris To: Marcus Prebble Cc: Marcus Prebble , "linux-mtd@lists.infradead.org" , Ricard =?iso-8859-1?Q?Wanderl=F6f?= , Richard Weinberger Subject: Re: [PATCH] mtd-utils: lib: mtd_read: Take the buffer offset into account when reading Message-ID: <20151113191748.GH8456@google.com> References: <20151112190924.GD8456@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, On Fri, Nov 13, 2015 at 11:07:12AM +0100, Marcus Prebble wrote: > Thanks for looking at the patch! Thanks for the patch! > On Thu, 2015-11-12 at 11:09 -0800, Brian Norris wrote: > > Patch looks OK. Did you test it? Have you seen MTD drivers that will > > return short reads? > > I only noticed in passing, not because I was hit by the error. I smoke > tested it, but did not hack a driver to return less than len. > If I had to guess, I would say that in nearly all cases the drivers do > not return short reads otherwise this would probably have been picked up > by now. OK, that's fine. It's good to know when things are likely to cause real problems vs. when things need fixed just for best practice. BTW, I noticed there isn't a 'Signed-off-by' tag in the patch. It's mostly a formality, but we really shouldn't be taking patches without it. Can you paste one in reply to your patch, and I'll C&P it? Regards, Brian