From: Brian Norris <computersforpeace@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition
Date: Fri, 27 Nov 2015 14:33:40 -0800 [thread overview]
Message-ID: <20151127223340.GB19615@localhost> (raw)
In-Reply-To: <CACna6rxs==Be4Ua_AUuqZgc8ey0DYXrgUOe=7TqxBEEF7AOzKw@mail.gmail.com>
On Fri, Nov 27, 2015 at 10:25:55AM +0100, Rafał Miłecki wrote:
> On 26 November 2015 at 09:05, Rafał Miłecki <zajec5@gmail.com> wrote:
> > So far struct spi_nor was using just a pointer to struct mtd_info so it
> > wasn't needed to have it fully defined there. After recent change we
> > embed whole struct so we need to include a proper header.
Good catch.
> > Fixes: 1976367173a4 ("mtd: spi-nor: embed struct mtd_info within struct spi_nor")
I'm not 100% sure, but I thought I recall the -stable folks picking up
for-linus commits just based on the 'Fixes:' tags. I feel like that
isn't always ideal, though.
> > Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>
> This may be worth taking as a fix for 4.4. However I'm not aware of
> any upstream driver failing to build because of this.
I don't see why it would need rushed out. All users of spi-nor.h
currently include mtd.h first. So there are no build failures because of
it.
Regards,
Brian
next prev parent reply other threads:[~2015-11-27 22:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 8:05 [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition Rafał Miłecki
2015-11-27 9:25 ` Rafał Miłecki
2015-11-27 22:33 ` Brian Norris [this message]
2015-11-28 14:05 ` Rafał Miłecki
2015-11-30 19:42 ` Brian Norris
2015-11-30 20:02 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151127223340.GB19615@localhost \
--to=computersforpeace@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).