* [PATCH] spi/nor: Fix error message with unrecognized JEDEC
@ 2015-11-30 15:25 Ricardo Ribalda Delgado
2015-11-30 16:46 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2015-11-30 15:25 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Rafał Miłecki,
Huang Shijie, Marek Vasut, Mika Westerberg, Gabor Juhos,
Bean Huo 霍斌斌 (beanhuo), Furquan Shaikh,
linux-mtd, linux-kernel
Cc: Ricardo Ribalda Delgado
The error message was:
m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0
The new error message:
m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index b7c038c75684..7d2b96d5f350 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct spi_nor *nor)
return &spi_nor_ids[tmp];
}
}
- dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
+ dev_err(nor->dev, "unrecognized JEDEC id bytes: %.2x, %.2x, %.2x\n",
id[0], id[1], id[2]);
return ERR_PTR(-ENODEV);
}
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] spi/nor: Fix error message with unrecognized JEDEC
2015-11-30 15:25 [PATCH] spi/nor: Fix error message with unrecognized JEDEC Ricardo Ribalda Delgado
@ 2015-11-30 16:46 ` Marek Vasut
2015-11-30 19:41 ` Ricardo Ribalda Delgado
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2015-11-30 16:46 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: David Woodhouse, Brian Norris, Rafał Miłecki,
Huang Shijie, Mika Westerberg, Gabor Juhos,
Bean Huo 霍斌斌 (beanhuo), Furquan Shaikh,
linux-mtd, linux-kernel
On Monday, November 30, 2015 at 04:25:11 PM, Ricardo Ribalda Delgado wrote:
> The error message was:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0
>
> The new error message:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index b7c038c75684..7d2b96d5f350 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct
> spi_nor *nor) return &spi_nor_ids[tmp];
> }
> }
> - dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
> + dev_err(nor->dev, "unrecognized JEDEC id bytes: %.2x, %.2x, %.2x\n",
You can change it to %02x to make it consistent, no ? What do you think ?
> id[0], id[1], id[2]);
> return ERR_PTR(-ENODEV);
> }
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi/nor: Fix error message with unrecognized JEDEC
2015-11-30 16:46 ` Marek Vasut
@ 2015-11-30 19:41 ` Ricardo Ribalda Delgado
0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2015-11-30 19:41 UTC (permalink / raw)
To: Marek Vasut
Cc: David Woodhouse, Brian Norris, Rafał Miłecki,
Huang Shijie, Mika Westerberg, Gabor Juhos,
Bean Huo 霍斌斌 (beanhuo), Furquan Shaikh,
linux-mtd@lists.infradead.org, LKML
Hello Marek
On Mon, Nov 30, 2015 at 5:46 PM, Marek Vasut <marex@denx.de> wrote:
> On Monday, November 30, 2015 at 04:25:11 PM, Ricardo Ribalda Delgado wrote:
>> The error message was:
>>
>> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0
>>
>> The new error message:
>>
>> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
>>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>> ---
>> drivers/mtd/spi-nor/spi-nor.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index b7c038c75684..7d2b96d5f350 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct
>> spi_nor *nor) return &spi_nor_ids[tmp];
>> }
>> }
>> - dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
>> + dev_err(nor->dev, "unrecognized JEDEC id bytes: %.2x, %.2x, %.2x\n",
>
> You can change it to %02x to make it consistent, no ? What do you think ?
Sure, no problem, it is just that I am more used to %.2 than %02 :)
>
>> id[0], id[1], id[2]);
>> return ERR_PTR(-ENODEV);
>> }
>
> Best regards,
> Marek Vasut
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-30 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-30 15:25 [PATCH] spi/nor: Fix error message with unrecognized JEDEC Ricardo Ribalda Delgado
2015-11-30 16:46 ` Marek Vasut
2015-11-30 19:41 ` Ricardo Ribalda Delgado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).